Skip to content

feat(sdk/python): add synchronous PoolManagerSync wrapper#359

Open
wangdengshan wants to merge 2 commits into
opensandbox-group:mainfrom
wangdengshan:feat/sdk-python-pool-manager-sync
Open

feat(sdk/python): add synchronous PoolManagerSync wrapper#359
wangdengshan wants to merge 2 commits into
opensandbox-group:mainfrom
wangdengshan:feat/sdk-python-pool-manager-sync

Conversation

@wangdengshan
Copy link
Copy Markdown
Contributor

Summary

  • Add synchronous PoolManagerSync wrapper to the Python SDK for blocking pool management
  • Add PoolsSync Protocol (blocking counterpart of async Pools)
  • Add PoolsAdapterSync using httpx.Client with sync_detailed calls
  • Add PoolManagerSync with static create() factory, blocking CRUD methods, and context manager (__enter__/__exit__)
  • Wire into AdapterFactorySync.create_pool_service()
  • Export PoolManagerSync from opensandbox.sync and root __init__

Testing

  • Unit tests
  • 55 tests covering service protocol, adapter HTTP routing, response mapping, manager delegation, lifecycle, and public exports

Breaking Changes

  • None

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

- Add PoolsSync Protocol (blocking counterpart of async Pools)
- Add PoolsAdapterSync using httpx.Client with sync_detailed calls
- Add PoolManagerSync with static create() factory, blocking CRUD
  methods, and context manager (__enter__/__exit__)
- Wire into AdapterFactorySync.create_pool_service()
- Export PoolManagerSync from opensandbox.sync and root __init__
- Add 55 tests covering service protocol, adapter HTTP routing,
  response mapping, manager delegation, lifecycle, and public exports
@wangdengshan wangdengshan requested a review from Pangjiping as a code owner May 25, 2026 08:46
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ This PR has no labels. Please add one based on the changes.

Changed directories: sdks.

📋 Recommended labels (based on changed files):

  • sdks ⬅️

Other available labels:

  • bug - Something isn't working
  • dependencies - Pull requests that update a dependency file
  • documentation - Improvements or additions to documentation
  • feature - New feature or request
  • packages - Changes for package, image and configuration

💡 Tip: Use feature for new functionality or improvements, bug for fixes.

cc @wangdengshan

@wangdengshan
Copy link
Copy Markdown
Contributor Author

Hi maintainers, could someone please add the sdks and feature labels to this PR? As an external contributor I do not have permission to add labels myself. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant