Skip to content

docs(osep): OSEP-0012 for multi tenant#838

Merged
hittyt merged 3 commits into
opensandbox-group:mainfrom
Pangjiping:feat/osep-multi-tenants
Jun 5, 2026
Merged

docs(osep): OSEP-0012 for multi tenant#838
hittyt merged 3 commits into
opensandbox-group:mainfrom
Pangjiping:feat/osep-multi-tenants

Conversation

@Pangjiping
Copy link
Copy Markdown
Collaborator

No description provided.

@Pangjiping Pangjiping added the documentation Improvements or additions to documentation label May 7, 2026
@Pangjiping Pangjiping mentioned this pull request May 7, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37d0c8b379

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread oseps/0012-multi-tenancy.md Outdated
Comment thread oseps/0012-multi-tenancy.md Outdated
Comment thread oseps/0012-multi-tenancy.md Outdated
Pangjiping and others added 2 commits May 7, 2026 11:21
- Replace code blocks with pseudocode/flows, ~40% shorter
- Add TenantProvider interface decoupling auth from config source
- FileTenantProvider as initial backend; room for HTTP/IAM providers
- Make Docker unsupported explicit across summary, goals, requirements

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Ingress gateway intentionally does not enforce tenant isolation.
Proxy routes bypass auth (design) — tenancy enforced at lifecycle API
boundary, not data-plane. Isolation via unguessable IDs + signed tokens.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

jwx0925 commented Jun 5, 2026

建议在 TenantProvider 抽象里把外部租户系统的缓存策略提前写清楚。

如果后续支持 HTTPTenantProvider / IAM 回调,认证链路不应每个请求都同步依赖外部系统,否则外部系统抖动会直接影响所有 lifecycle API。建议设计里明确:

  • provider 需要支持本地内存缓存;
  • 后台刷新完整 tenant/key 映射,或对 lookup 结果使用短 TTL cache;
  • key 撤销的最大生效延迟应由 TTL/刷新间隔定义清楚;
  • 外部系统超时、5xx、返回异常时的策略需要明确,建议默认 fail-closed,但可允许在已有缓存未过期时继续使用;
  • list_tenants() 如果用于启动 namespace 校验,也需要说明外部 provider 是返回完整租户列表,还是改为请求时按 tenant 做延迟校验。

这样 TenantProvider 不只是文件 provider 的接口,也能覆盖未来接 IAM/tenant-management 系统时的可用性和安全边界。

Copy link
Copy Markdown
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit 5053fb6 into opensandbox-group:main Jun 5, 2026
3 checks passed
@Pangjiping Pangjiping deleted the feat/osep-multi-tenants branch June 5, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants