feat(sdk): add skipAccumulation to prevent OutputMessage OOM#990
Open
Pangjiping wants to merge 1 commit into
Open
feat(sdk): add skipAccumulation to prevent OutputMessage OOM#990Pangjiping wants to merge 1 commit into
Pangjiping wants to merge 1 commit into
Conversation
…t OOM When streaming handlers are provided for long-running executions, the SDK unconditionally accumulates every stdout/stderr message in memory, causing OOM for executions with large output volumes. Add `skipAccumulation` (default false) to ExecutionHandlers across all SDK languages. When enabled, messages are delivered to handler callbacks without being appended to ExecutionLogs, allowing constant-memory streaming. Closes opensandbox-group#981 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 642a5e3e5b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipAccumulationoption toExecutionHandlersacross all SDK languages (Kotlin, Python async/sync, TypeScript, Go, C#)ExecutionLogs, enabling constant-memory streaming for long-running executionsfalse— fully backward compatible, no breaking changesMotivation
Production OOM caused by unbounded
OutputMessageaccumulation when streaming handlers are provided (41M objects observed in Java heap dump). Users who provide streaming handlers have no way to opt out of message buffering.Changes
ExecutionModels.kt,ExecutionEventDispatcher.ktexecd.py,execution_event_dispatcher.pyexecd_sync.py, syncexecution_event_dispatcher.pyexecution.ts,executionEventDispatcher.tsexecution.goExecution.cs,ExecutionEventDispatcher.csTest plan
go test ./...passesnpx tsc --noEmit+npm testpassespytestpasses + manual import verificationCloses #981
🤖 Generated with Claude Code