Skip to content

Refactor models list#39

Open
alirezazolanvari wants to merge 16 commits intodevfrom
refactor-models-list
Open

Refactor models list#39
alirezazolanvari wants to merge 16 commits intodevfrom
refactor-models-list

Conversation

@alirezazolanvari
Copy link
Member

  • Centralize models registries in params.py
  • Replace abstractmethods in DrugReleaseModel using configs from models registries
  • Remove parameter dataclasses of the models
  • Set default value 1 for the Entire releasable amount (M_0/M) in the respective models
  • Reformat by black

@alirezazolanvari alirezazolanvari self-assigned this Feb 24, 2026
@alirezazolanvari alirezazolanvari added the enhancement New feature or request label Feb 24, 2026
@alirezazolanvari alirezazolanvari added this to the drux v0.4 milestone Feb 24, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 93.93939% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.11%. Comparing base (0e582b3) to head (92448a5).

Files with missing lines Patch % Lines
drux/base_model.py 77.78% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #39      +/-   ##
==========================================
- Coverage   98.73%   97.11%   -1.61%     
==========================================
  Files           9       10       +1     
  Lines         235      173      -62     
  Branches       26       18       -8     
==========================================
- Hits          232      168      -64     
  Misses          2        2              
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alirezazolanvari alirezazolanvari marked this pull request as ready for review February 24, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants