Skip to content

Add sklearn compose models#264

Merged
sadrasabouri merged 36 commits intodevfrom
add/sklearn_compose
Jan 22, 2026
Merged

Add sklearn compose models#264
sadrasabouri merged 36 commits intodevfrom
add/sklearn_compose

Conversation

@AHReccese
Copy link
Member

Reference Issues/PRs

#263 #226

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese self-assigned this Dec 30, 2025
@AHReccese AHReccese added this to the pymilo v1.5 milestone Dec 30, 2025
@AHReccese AHReccese added new feature major major changes, to be reviewed in 10 days labels Dec 30, 2025
@AHReccese AHReccese marked this pull request as ready for review January 1, 2026 00:26
@AHReccese AHReccese requested a review from sadrasabouri January 1, 2026 00:26
@AHReccese
Copy link
Member Author

Hey folks, @sepandhaghighi @sadrasabouri
To avoid getting stuck, I prepared this PR. Some refactoring may still be needed and can be addressed in separate PRs (if you notice any). Please let me know your thoughts. I also tried to avoid going down rabbit holes in order to provide smooth, incremental updates.

After some minor PRs after this PR, we can have the 1.5 release.

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.83%. Comparing base (06716ac) to head (3e47bb4).
⚠️ Report is 150 commits behind head on dev.

Files with missing lines Patch % Lines
...transporters/general_data_structure_transporter.py 58.63% 7 Missing and 5 partials ⚠️
pymilo/transporters/compose_transporter.py 87.33% 4 Missing and 5 partials ⚠️
pymilo/chains/compose_chain.py 77.78% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #264       +/-   ##
===========================================
- Coverage   87.40%   74.83%   -12.56%     
===========================================
  Files          31       51       +20     
  Lines        1142     2455     +1313     
  Branches      201      451      +250     
===========================================
+ Hits          998     1837      +839     
- Misses         90      518      +428     
- Partials       54      100       +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi
Copy link
Member

@AHReccese

Thanks for your efforts. It's a giant pull request. I will review it within the next 5-6 days.

Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me in general. I left some minor refactoring issues that can be addressed later in a separate PR, as you mentioned. I also raised a question about a default value.
Final review by @sepandhaghighi is necessary, though since this is a huge PR and I might have missed some logical code issues.

@AHReccese
Copy link
Member Author

Thank you, Sadra @sadrasabouri, for your review. I will address them ASAP.
Sepand @sepandhaghighi, you can wait until I apply Sadra's feedback, and then I can ping you so that you can proceed with your review.

@AHReccese AHReccese removed the request for review from sepandhaghighi January 19, 2026 04:14
…te names for BSpline, improving compatibility with different data formats
@AHReccese
Copy link
Member Author

AHReccese commented Jan 19, 2026

Thank you, Sadra @sadrasabouri, for your review. I will address them ASAP. Sepand @sepandhaghighi, you can wait until I apply Sadra's feedback, and then I can ping you so that you can proceed with your review.

Dear Sadra @sadrasabouri, I've applied your feedback, feel free to reach out to discuss more. We will do the review for this PR with only you (due to the current situation).

@sadrasabouri
Copy link
Member

OK, I will review this soon. Please don't resolve the comments and let the reviewer do that. It helps with contextualizing.

Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, which are again all refactors; Feel free to merge and fix them in future PR. It's up to you.

@sadrasabouri sadrasabouri merged commit 9d87053 into dev Jan 22, 2026
25 checks passed
@sadrasabouri sadrasabouri deleted the add/sklearn_compose branch January 22, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major major changes, to be reviewed in 10 days new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for sklearn compose models [Bug]: Export fails for Pipeline containing TransformedTargetRegressor

3 participants