Conversation
…sList and slice objects
…nating pandas dependency in favor of numpy arrays
…g and avoid unnecessary directory removal
|
Hey folks, @sepandhaghighi @sadrasabouri After some minor PRs after this PR, we can have the 1.5 release. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #264 +/- ##
===========================================
- Coverage 87.40% 74.83% -12.56%
===========================================
Files 31 51 +20
Lines 1142 2455 +1313
Branches 201 451 +250
===========================================
+ Hits 998 1837 +839
- Misses 90 518 +428
- Partials 54 100 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your efforts. It's a giant pull request. I will review it within the next 5-6 days. |
sadrasabouri
left a comment
There was a problem hiding this comment.
It looks good to me in general. I left some minor refactoring issues that can be addressed later in a separate PR, as you mentioned. I also raised a question about a default value.
Final review by @sepandhaghighi is necessary, though since this is a huge PR and I might have missed some logical code issues.
|
Thank you, Sadra @sadrasabouri, for your review. I will address them ASAP. |
…n docstrings, streamline model type checks
…ion and deserialization functions
…unctionType for improved function handling
…r serialization and deserialization, enhancing flexibility in data handling
…te names for BSpline, improving compatibility with different data formats
Dear Sadra @sadrasabouri, I've applied your feedback, feel free to reach out to discuss more. We will do the review for this PR with only you (due to the current situation). |
|
OK, I will review this soon. Please don't resolve the comments and let the reviewer do that. It helps with contextualizing. |
sadrasabouri
left a comment
There was a problem hiding this comment.
Minor changes, which are again all refactors; Feel free to merge and fix them in future PR. It's up to you.
Reference Issues/PRs
#263 #226
What does this implement/fix? Explain your changes.
Any other comments?