Fix UnicodeDecodeError on Windows when upload fails#123
Open
Fix UnicodeDecodeError on Windows when upload fails#123
Conversation
… improving decoding logic for error messages.
AHReccese
requested review from
sadrasabouri
and removed request for
sepandhaghighi
Member
Author
|
@sadrasabouri |
sadrasabouri
reviewed
Mar 5, 2026
Member
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
The badges look good but I don't have Windows to verify the other part. Can you add a test that reproduce the case?
I left some minor comments to.
| error = error.decode('utf-8') | ||
| if error is None: | ||
| error = "Unknown error (no output captured)" | ||
| elif isinstance(error, bytes): |
Comment on lines
+133
to
+139
| if encoding: | ||
| try: | ||
| error = error.decode(encoding) | ||
| except (UnicodeDecodeError, LookupError): | ||
| error = error.decode('utf-8', errors='replace') | ||
| else: | ||
| error = error.decode('utf-8', errors='replace') |
Member
There was a problem hiding this comment.
can't we simplify if by bringing back try/except one indent and adding the error due to encoding being None to the list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#122 +
Replace
shields.ioGitHub stars badge withbadgen.netdue to frequent recentshields.ioservice issuesWhat does this implement/fix? Explain your changes.
Any other comments?