Skip to content

Revert "[Sandbox SQL snapshot] Pin org.opensearch.query:* (unified-qu…#21580

Merged
mch2 merged 1 commit intoopensearch-project:mainfrom
mch2:revert
May 9, 2026
Merged

Revert "[Sandbox SQL snapshot] Pin org.opensearch.query:* (unified-qu…#21580
mch2 merged 1 commit intoopensearch-project:mainfrom
mch2:revert

Conversation

@mch2
Copy link
Copy Markdown
Member

@mch2 mch2 commented May 9, 2026

…ery-*) snapshots to mavenLocal (#21578)"

This reverts commit 36809cc.

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ery-*) snapshots to mavenLocal (opensearch-project#21578)"

This reverts commit 36809cc.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2 mch2 requested a review from a team as a code owner May 9, 2026 18:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 599a5c2.

PathLineSeverityDescription
sandbox/plugins/test-ppl-frontend/build.gradle35highUnrestricted mavenLocal() repository added. Previously mavenLocal was scoped exclusively to 'org.opensearch.query' group via includeGroup filter. The replacement bare mavenLocal() allows any artifact in the local Maven cache (~/.m2) to shadow remote dependencies, significantly expanding the supply chain attack surface in CI/CD environments where the local cache may be writeable by untrusted processes.
sandbox/build.gradle49highRemoval of the restricted mavenLocal repository block (mavenContent { includeGroup 'org.opensearch.query' }) from the root subprojects repositories configuration. This is a repository configuration change that alters dependency resolution behavior across all sandbox subprojects; maintainers should verify the intended resolution order is preserved.
sandbox/plugins/analytics-engine/build.gradle22highDependency version downgrade: sqlUnifiedQueryVersion changed from '3.7.0.0-SNAPSHOT' to '3.6.0.0-SNAPSHOT'. Downgrading to an older SNAPSHOT introduces a different (older) artifact than was previously validated. Removed comments had explicitly documented why 3.7 was required; this reversal should be verified against the current state of the feature branch.
sandbox/plugins/test-ppl-frontend/build.gradle38highRemoval of mavenContent { excludeGroup 'org.opensearch.query' } filter from the OpenSearch Snapshots repository. This filter previously prevented the remote snapshots repo from serving org.opensearch.query artifacts. Its removal changes which remote source resolves this group and should be verified to ensure the correct artifact version is resolved.
sandbox/plugins/analytics-backend-datafusion/build.gradle19highRemoval of mavenContent { excludeGroup 'org.opensearch.query' } filter from the OpenSearch Snapshots repository in the analytics-backend-datafusion subproject. As with other subprojects, this changes the dependency resolution path for the org.opensearch.query group and is a repository configuration change that must be verified by maintainers.

The table above displays the top 10 most important findings.

Total: 5 | Critical: 0 | High: 5 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@mgodwan mgodwan added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label May 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

✅ Gradle check result for 599a5c2: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.42%. Comparing base (36809cc) to head (599a5c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #21580      +/-   ##
============================================
- Coverage     73.50%   73.42%   -0.09%     
+ Complexity    74644    74527     -117     
============================================
  Files          5980     5980              
  Lines        338777   338777              
  Branches      48848    48848              
============================================
- Hits         249011   248735     -276     
- Misses        69946    70155     +209     
- Partials      19820    19887      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mch2 mch2 merged commit f97a81c into opensearch-project:main May 9, 2026
31 of 33 checks passed
bowenlan-amzn added a commit to bowenlan-amzn/OpenSearch that referenced this pull request May 10, 2026
These dependencies (unified-query-api/core/ppl) were added in opensearch-project#21578 and
then reverted in opensearch-project#21580. They were incorrectly re-introduced during
conflict resolution.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants