Extract shared HTTP client auth into http-client-common module#6776
Open
srikanthpadakanti wants to merge 3 commits intoopensearch-project:mainfrom
Open
Extract shared HTTP client auth into http-client-common module#6776srikanthpadakanti wants to merge 3 commits intoopensearch-project:mainfrom
srikanthpadakanti wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
srikanthpadakanti
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Contributor
Author
|
Hello @dlvenable @kkondaka Please review this. |
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per @kkondaka's feedback on #6743, the Basic Auth and Bearer Token auth in the Prometheus scrape source are generic enough to be reused by other HTTP-based sources and sinks. This PR pulls them into a new http-client-common module so plugins like http-source, http-sink, and prometheus-source can share the same auth code instead of each rolling their own.
Also makes it easier to add new auth schemes (like SigV4) down the road since you'd only implement it once.
Issues Resolved
Resolves #6767
#6767
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.