Add legacy MD5 checksum validation#6790
Open
simonelbaz wants to merge 3 commits intoopensearch-project:mainfrom
Open
Add legacy MD5 checksum validation#6790simonelbaz wants to merge 3 commits intoopensearch-project:mainfrom
simonelbaz wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
simonelbaz
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Author
|
The PR needs some permission to pass the failed check. Thanks for any review & help. |
Member
|
@simonelbaz , Will this supersede #6356 ? |
Author
Yes, it will. |
dlvenable
reviewed
Apr 30, 2026
Member
|
@simonelbaz , Your second commit appears to have the wrong DCO. Please correct. |
simonelbaz
force-pushed
the
md5checksum-2
branch
2 times, most recently
from
d9de5b9 to
19c29eb
Compare
dlvenable
previously approved these changes
May 1, 2026
Member
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thanks for the contribution @simonelbaz !
Author
|
@dlvenable : thanks for your feedback. Is it slated to be merged to main branch pls? |
Member
|
@simonelbaz , There are merge conflicts to merge to |
Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
Signed-off-by: Simon ELBAZ <elbazsimon9@gmail.com>
Author
@dlvenable : rebase done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some S3 compatible storages still use legacy MD5 checksum validation.
With this patch, it will be possible to activate MD5 algorithm (optional).
Issues Resolved
Resolves #6780 , #6340
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.