Generate JSON schemas for plugins with schema definitions for nested configurations#6814
Merged
dlvenable merged 2 commits intoopensearch-project:mainfrom May 6, 2026
Merged
Conversation
…es instead of using object. Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: David Venable <dlv@amazon.com>
Zhangxunmt
approved these changes
May 4, 2026
| package org.opensearch.dataprepper.schemas; | ||
|
|
||
| public class JsonSchemaConverterConfig { | ||
| private final boolean useDefinitions; |
Collaborator
There was a problem hiding this comment.
This class might be redundant? If there's no plan to add more options, just passing boolean useDefinitions directly to convertIntoJsonSchema would be simpler.
Member
Author
There was a problem hiding this comment.
I didn't want to keep changing the method parameters as the options changed and this was no additional work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current schema generation uses
objectfor nested configurations. With the nested configurations, the nested configurations are not referenced. This makes it difficult to auto-generate documentation from the schemas.This PR adds a new
--use_definitions=trueconfiguration to the schema generation that generates a schema instead of object.Here is how it generates currently for the
dateprocessor (some parts are removed to focus on the change):With this change, we get this output instead (again, some parts removed):
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.