Auto generate test PEM files at runtime using BouncyCastle#6827
Merged
dlvenable merged 6 commits intoopensearch-project:mainfrom May 7, 2026
Merged
Conversation
srikanthpadakanti
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
requested changes
May 6, 2026
Member
dlvenable
left a comment
dlvenable
left a comment
There was a problem hiding this comment.
Thanks @srikanthpadakanti !
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
srikanthpadakanti
force-pushed
the
auto-generate-pem-6826
branch
from
df7695d to
09f2d39
Compare
The connectionConfiguration local variable was moved out of doInitializeInternal scope by PR opensearch-project#6795. Use the getter from openSearchSinkConfig instead. Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Replace File.deleteOnExit() with JUnit @tempdir so generated PEM files are cleaned up reliably by the test framework. Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
The verification RestClient also needs to present a client certificate when OpenSearch has clientauth_mode: REQUIRE. Added a local client builder with client cert support. Also simplified the workflow mTLS config logic with prefix detection. Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Contributor
Author
|
@dlvenable AWS secrets test is unrelated to this change. main has a compile error in OpenSearchSink.java where #6771 references a constructor-local variable from |
…refactor" This reverts commit e96d89d. Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
dlvenable
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace static PEM test files with runtime generated certificates using
BouncyCastlefor the OpenSearch sink mTLS tests. The test CA is now generated with proper BasicConstraints and KeyUsage extensions. Added edge case tests for wrong CA rejection and inline PEM content support.Issues Resolved
Resolves #6826
#6826
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.