[Backport 2.18] [Backport 2.x] Resolve Alias Issues in Legacy SQL with Filters#3109
Merged
[Backport 2.18] [Backport 2.x] Resolve Alias Issues in Legacy SQL with Filters#3109
Conversation
* Fix: Pagination of index aliases is not supported * fix: remove extra debug log * Integration testadded * rollback change Signed-off-by: Aparajita Pandey<aparajita31pandey@gmail.com> * Integration TestAdded Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Integration TestAdded Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * SpotlessCheck Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> --------- (cherry picked from commit 564ab60) Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 2921f2e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Swiddis
approved these changes
Oct 23, 2024
derek-ho
approved these changes
Oct 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.18 #3109 +/- ##
=========================================
Coverage 94.49% 94.49%
Complexity 5422 5422
=========================================
Files 529 529
Lines 15464 15464
Branches 1011 1011
=========================================
Hits 14613 14613
Misses 804 804
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 2921f2e from #3059.