[Backport 2.19-dev] TPCH: Try to improve logging for invalid values#5121
Merged
[Backport 2.19-dev] TPCH: Try to improve logging for invalid values#5121
Conversation
* Another TCPH fix: Wait for all shards Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Set replicas to 0 for integ test mappings by default Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add more ctx to a comment Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Maybe more debugging in matcher utils? Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit b60ba30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
LantaoJin
approved these changes
Feb 6, 2026
qianheng-aws
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport b60ba30 from #5111.