Skip to content

Conversation

@yasun1
Copy link
Contributor

@yasun1 yasun1 commented Jan 20, 2026

Summary by CodeRabbit

  • Documentation

    • Updated configuration documentation to reflect new environment variable naming conventions.
  • Chores

    • Standardized environment variable prefixes to HYPERFLEET_ for logging and database configurations (e.g., HYPERFLEET_LOG_LEVEL, HYPERFLEET_LOG_FORMAT, HYPERFLEET_DB_DEBUG).
    • Default logging output format changed from JSON to text.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci openshift-ci bot requested review from crizzo71 and mbrudnoy January 20, 2026 07:28
@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 86254860 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Walkthrough

This pull request standardizes environment variable naming conventions by prefixing LOG-related variables (LOG_LEVEL, LOG_FORMAT, LOG_OUTPUT), masking variables (MASKING_ENABLED, MASKING_HEADERS, MASKING_FIELDS), and database debug variables (DB_DEBUG) with a HYPERFLEET_ prefix. Additionally, the default logging format is changed from JSON to text. Changes span configuration files, tests, and documentation to maintain consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

lgtm, approved

Suggested reviewers

  • crizzo71
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: standardizing environment variables by adding a HYPERFLEET_ prefix across configuration files, which is the core focus of all modifications.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
pkg/config/db.go (1)

138-140: Update stale comment to reference new environment variable names.

The comment references the old DB_DEBUG and LOG_LEVEL names instead of HYPERFLEET_DB_DEBUG and HYPERFLEET_LOG_LEVEL.

Suggested fix
-// GetGormLogLevel returns the appropriate GORM log level based on DB_DEBUG and LOG_LEVEL.
-// DB_DEBUG=true always returns Info level, otherwise follows LOG_LEVEL mapping.
+// GetGormLogLevel returns the appropriate GORM log level based on HYPERFLEET_DB_DEBUG and HYPERFLEET_LOG_LEVEL.
+// HYPERFLEET_DB_DEBUG=true always returns Info level, otherwise follows HYPERFLEET_LOG_LEVEL mapping.
docs/logging.md (1)

428-434: Stale environment variable reference in Data Masking section.

Line 430 still references MASKING_ENABLED=true instead of the new HYPERFLEET_MASKING_ENABLED=true.

Suggested fix
-Sensitive data is automatically masked when `MASKING_ENABLED=true`:
+Sensitive data is automatically masked when `HYPERFLEET_MASKING_ENABLED=true`:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant