Skip to content

telco-ran: add gnrd extra-manifests#712

Open
abraham2512 wants to merge 1 commit intoopenshift-kni:mainfrom
abraham2512:update-clusterinstance-kustomize-rename-ptp-gnrd
Open

telco-ran: add gnrd extra-manifests#712
abraham2512 wants to merge 1 commit intoopenshift-kni:mainfrom
abraham2512:update-clusterinstance-kustomize-rename-ptp-gnrd

Conversation

@abraham2512
Copy link
Copy Markdown
Member

Include gnrd rename extra-manifests in stock clusterinstance kustomization

@openshift-ci openshift-ci Bot requested review from SchSeba and ffromani April 14, 2026 18:14
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abraham2512
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c29ea772-da1e-4ba5-a1ad-cc41d7014c71

📥 Commits

Reviewing files that changed from the base of the PR and between e7ec33f and 26ed5a0.

📒 Files selected for processing (1)
  • telco-ran/configuration/argocd/example/clusterinstance/kustomization.yaml

📝 Walkthrough

Walkthrough

A Kustomize manifest file is updated to add two commented-out entries to the configMapGenerator file list, referencing additional manifest files for renaming GNRD interfaces on master and worker nodes. No active configuration changes are made.

Changes

Cohort / File(s) Summary
Kustomize Manifest Configuration
telco-ran/configuration/argocd/example/clusterinstance/kustomization.yaml
Added two commented-out configMapGenerator entries for extra-manifest/10-rename-gnrd-interfaces-master.yaml and extra-manifest/10-rename-gnrd-interfaces-worker.yaml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'telco-ran: add gnrd extra-manifests' accurately describes the main change: adding GNRD extra-manifest entries to the kustomization configuration.
Description check ✅ Passed The description 'Include gnrd rename extra-manifests in stock clusterinstance kustomization' directly relates to the changeset, describing the addition of GNRD rename extra-manifests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant