OCPBUGS-83541: telco-ran: add check for optional kubeletconfig annotation#714
OCPBUGS-83541: telco-ran: add check for optional kubeletconfig annotation#714abraham2512 wants to merge 1 commit intoopenshift-kni:release-4.20from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abraham2512 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@abraham2512: This pull request references Jira Issue OCPBUGS-83541, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@abraham2512: This pull request references Jira Issue OCPBUGS-83541, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| {{- range $value := $expectedArgs }} | ||
| {{- $result = append $result $value }} | ||
| {{- end }} | ||
| {{- if ne (index . 0) nil }} |
There was a problem hiding this comment.
Should the same test from line 29 be extended to cover this as well. ie move the {{ end }} from line 31 to line 45?
This PR adds a check around the kubeletconfig.experimental template to not show diff if the annotation is absent