Skip to content

OCPBUGS-83541: telco-ran: add check for optional kubeletconfig annotation#714

Open
abraham2512 wants to merge 1 commit intoopenshift-kni:release-4.20from
abraham2512:perf-profile-ref-template
Open

OCPBUGS-83541: telco-ran: add check for optional kubeletconfig annotation#714
abraham2512 wants to merge 1 commit intoopenshift-kni:release-4.20from
abraham2512:perf-profile-ref-template

Conversation

@abraham2512
Copy link
Copy Markdown
Member

@abraham2512 abraham2512 commented Apr 15, 2026

This PR adds a check around the kubeletconfig.experimental template to not show diff if the annotation is absent

@openshift-ci openshift-ci Bot requested review from irinamihai and yuvalk April 15, 2026 17:34
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abraham2512
Once this PR has been reviewed and has the lgtm label, please assign lack for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f87cee47-7190-48f0-9fc9-45149cbe5e8e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@abraham2512 abraham2512 changed the title telco-ran: add check for optional kubeletconfig annotation OCPBUGS-83541: telco-ran: add check for optional kubeletconfig annotation Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-83541, which is invalid:

  • expected the bug to target the "4.20.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-83541 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR adds a check around the kubeletconfig.experimental template to not show diff if the annotation is missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-83541, which is invalid:

  • expected the bug to target the "4.20.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-83541 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This PR adds a check around the kubeletconfig.experimental template to not show diff if the annotation is absent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

{{- range $value := $expectedArgs }}
{{- $result = append $result $value }}
{{- end }}
{{- if ne (index . 0) nil }}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the same test from line 29 be extended to cover this as well. ie move the {{ end }} from line 31 to line 45?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants