Skip to content

OCPBUGS-83763: telco-ran: enable ptp operator config for event in example#718

Open
abraham2512 wants to merge 1 commit intoopenshift-kni:mainfrom
abraham2512:ptp-config-example
Open

OCPBUGS-83763: telco-ran: enable ptp operator config for event in example#718
abraham2512 wants to merge 1 commit intoopenshift-kni:mainfrom
abraham2512:ptp-config-example

Conversation

@abraham2512
Copy link
Copy Markdown
Member

Un comment ptp operator config for event in ran manifests

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-83763, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Un comment ptp operator config for event in ran manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abraham2512
Once this PR has been reviewed and has the lgtm label, please assign irinamihai for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from MarSik and yuvalk April 20, 2026 01:21
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: caeef7a5-4ab4-42b7-b107-611b5af9a5e7

📥 Commits

Reviewing files that changed from the base of the PR and between 64c4814 and 855b078.

📒 Files selected for processing (1)
  • telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-sno-ranGen.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-sno-ranGen.yaml

📝 Walkthrough

Walkthrough

A PolicyGenerator entry in telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-sno-ranGen.yaml is activated for the PTP operator, using source-crs/ptp-operator/PtpOperatorConfig-SetSelector.yaml with complianceType: mustonlyhave and a patch that sets spec.daemonNodeSelector.node-role.kubernetes.io/master to an empty string.

Changes

Cohort / File(s) Summary
PTP Operator Policy Configuration
telco-ran/configuration/argocd/example/acmpolicygenerator/acm-group-du-sno-ranGen.yaml
Replaced previously commented PolicyGenerator entry with an active entry referencing source-crs/ptp-operator/PtpOperatorConfig-SetSelector.yaml. complianceType remains mustonlyhave; patch now sets spec.daemonNodeSelector.node-role.kubernetes.io/master: "" (was previously the worker selector).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references enabling PTP operator config for events in the telco-ran example, which matches the changeset that uncomments and modifies the PTP operator policy entry.
Description check ✅ Passed The description is directly related to the changeset, describing the uncommentation of PTP operator config for events in RAN manifests, which aligns with the actual changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Enable PtpOperatorConfig-SetSelector in the SNO policy with
mustonlyhave compliance and master node selector passed via patch.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# daemonNodeSelector:
# node-role.kubernetes.io/worker: ""
- path: source-crs/ptp-operator/PtpOperatorConfig-SetSelector.yaml
complianceType: "mustonlyhave"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "mustonlyhave" compliance type here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants