Update the AGENTS.md with additional knowledge on the telco-reference…#720
Update the AGENTS.md with additional knowledge on the telco-reference…#720imiller0 wants to merge 1 commit intoopenshift-kni:mainfrom
Conversation
… repository Signed-off-by: Ian Miller <imiller@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imiller0 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughAdded comprehensive documentation to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Around line 151-153: The docs incorrectly instruct running the non-existent
root-level make target "make compare"; update AGENTS.md to either (a) call the
correct subdirectory invocation(s) where the "compare" target actually lives
(e.g., cd into the specific subdirectory(s) and run make compare there) or (b)
add a root-level "compare" make target that delegates to the subdirectory
compare targets (similar to the existing "ci-validate" delegation), ensuring the
README references the chosen approach and that the target name "compare" is
accurate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| ```bash | ||
| make compare # Validates sync between deployable and validation variants | ||
| ``` |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify make targets at root and subdirectory levels
echo "=== Root Makefile targets ==="
grep -E '^[a-zA-Z_-]+:' Makefile | head -20
echo -e "\n=== Searching for 'compare' targets in subdirectories ==="
fd -t f '^Makefile$' -x grep -l 'compare:' {}
echo -e "\n=== Examining compare target definitions ==="
rg -A2 '^compare:' --type makeRepository: openshift-kni/telco-reference
Length of output: 1305
Incorrect make target: make compare does not exist at repository root.
The documentation instructs users to run make compare, but this target only exists in specific subdirectory Makefiles, not at the root level where users would naturally execute it. Users following these instructions will encounter a "No rule to make target 'compare'" error.
📝 Suggested correction
Update the documentation to specify the correct subdirectory commands:
-make compare # Validates sync between deployable and validation variants
+# Run from respective configuration directories:
+cd telco-ran/configuration/kube-compare-reference && make compare
+cd telco-hub/configuration/reference-crs-kube-compare && make compareAlternatively, add a root-level compare target that delegates to subdirectories (similar to ci-validate).
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ```bash | |
| make compare # Validates sync between deployable and validation variants | |
| ``` |
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 151-151: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@AGENTS.md` around lines 151 - 153, The docs incorrectly instruct running the
non-existent root-level make target "make compare"; update AGENTS.md to either
(a) call the correct subdirectory invocation(s) where the "compare" target
actually lives (e.g., cd into the specific subdirectory(s) and run make compare
there) or (b) add a root-level "compare" make target that delegates to the
subdirectory compare targets (similar to the existing "ci-validate" delegation),
ensuring the README references the chosen approach and that the target name
"compare" is accurate.
|
/hold |
… repository