OCPBUGS-85484: Update appliance config to use lvm-operator

[bfournie]

The lvm-operator is being included as a dependency for CNV, instead of lso-operator. This change updates the appliance-config.

Summary by CodeRabbit

Release Notes

• Chores
  • Updated operator configurations in appliance builds for versions 4.23 and 5.0.

[openshift-ci-robot]

@bfournie: This pull request references Jira Issue OCPBUGS-85484, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The lvm-operator is being included as a dependency for CNV, instead of lso-operator. This change updates the appliance-config.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4bcb7b6d-f8b3-425f-883d-4cf6bae4d27c

📥 Commits

Reviewing files that changed from the base of the PR and between eaafc6c and 9745051.

📒 Files selected for processing (2)

• tools/iso_builder/config/4.23/appliance-config.yaml
• tools/iso_builder/config/5.0/appliance-config.yaml

---

Walkthrough

Update operator configurations in the iso_builder tool across version-specific appliance configs. Replace local-storage-operator with lvms-operator in the 4.23 config and add lvms-operator to the 5.0 config, both configured on the stable-4.21 channel.

Changes

Operator Catalog Configuration Updates

Layer / File(s)	Summary
Version 4.23 operator replacement tools/iso_builder/config/4.23/appliance-config.yaml	Replace local-storage-operator (channel: stable) with lvms-operator (channel: stable-4.21) in the operators list.
Version 5.0 operator addition tools/iso_builder/config/5.0/appliance-config.yaml	Add lvms-operator with channel stable-4.21 to the operators list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions 'lvm-operator' but the actual changes replace 'local-storage-operator' with 'lvms-operator' (note the 's'). The title appears to have a typo that creates a discrepancy with the actual implementation.	Update the title to 'OCPBUGS-85484: Update appliance config to use lvms-operator' to accurately reflect that the operator being adopted is 'lvms-operator', not 'lvm-operator'.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names are stable and deterministic. No dynamic values (UUIDs, timestamps, pod/node names, IP addresses) found in any test titles. All tests use clear, static, descriptive names.
Test Structure And Quality	✅ Passed	PR does not modify Ginkgo test code. Changes are to YAML config files and infrastructure files only. Check is not applicable to this PR.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added in this PR. The changes only update YAML appliance configuration files. The MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only YAML configuration files for appliance operator settings. No Ginkgo e2e tests are added, so the SNO compatibility check is not applicable to this PR.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only appliance-config YAML files listing operators for agent-based installer ISOs. No deployment manifests, scheduling constraints, or topology-specific code introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML configuration files, not Go code. OTE Binary Stdout Contract check applies only to Go process-level functions, not applicable here.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds unit tests (app_test.go, apptester_test.go) but no Ginkgo e2e tests. The custom check only applies to Ginkgo e2e tests, so it's not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bfournie]

/hold
Depends on openshift/assisted-service#10285

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@bfournie: This pull request references Jira Issue OCPBUGS-85484, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

The lvm-operator is being included as a dependency for CNV, instead of lso-operator. This change updates the appliance-config.

Summary by CodeRabbit

Release Notes

• Chores
• Updated operator configurations in appliance builds for versions 4.23 and 5.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andfasano]

/lgtm

[openshift-ci]

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.