Skip to content

MCO-1870: Update MachineConfigNode printcolumns #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isabella-janssen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MCO-1870: Update MachineConfigNode printcolumns #2678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion machineconfiguration/v1/types_machineconfignode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ import (
// +kubebuilder:printcolumn:name="UpdatePostActionComplete",type="string",JSONPath=.status.conditions[?(@.type=="UpdatePostActionComplete")].status,priority=1
// +kubebuilder:printcolumn:name="UpdateComplete",type="string",JSONPath=.status.conditions[?(@.type=="UpdateComplete")].status,priority=1
// +kubebuilder:printcolumn:name="Resumed",type="string",JSONPath=.status.conditions[?(@.type=="Resumed")].status,priority=1
// +kubebuilder:printcolumn:name="UpdatedFilesAndOS",type="string",JSONPath=.status.conditions[?(@.type=="AppliedFilesAndOS")].status,priority=1
// +kubebuilder:printcolumn:name="AppliedOSImage",type="string",JSONPath=.status.conditions[?(@.type=="AppliedOSImage")].status,priority=1
// +kubebuilder:printcolumn:name="AppliedFiles",type="string",JSONPath=.status.conditions[?(@.type=="AppliedFiles")].status,priority=1
Comment on lines -26 to +27
Copy link
Contributor

@everettraven everettraven Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked back at the .status.conditions field and it is mentioned that the AppliedOSImage and AppliedFiles conditions are only available when the ImageModeStatusReporting feature gate is enabled.

I took a look and it looks like that feature gate isn't enabled by default:

api/features/features.go

Lines 277 to 283 in c16ec2b

FeatureGateImageModeStatusReporting = newFeatureGate("ImageModeStatusReporting").
reportProblemsToJiraComponent("MachineConfigOperator").
contactPerson("ijanssen").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1809").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

Are these status conditions no longer blocked by enablement of the feature gate?

// +kubebuilder:printcolumn:name="CordonedNode",type="string",JSONPath=.status.conditions[?(@.type=="Cordoned")].status,priority=1
// +kubebuilder:printcolumn:name="DrainedNode",type="string",JSONPath=.status.conditions[?(@.type=="Drained")].status,priority=1
// +kubebuilder:printcolumn:name="RebootedNode",type="string",JSONPath=.status.conditions[?(@.type=="RebootedNode")].status,priority=1
Expand Down
8 changes: 6 additions & 2 deletions ...anifests/0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...ed.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...ests/0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...erated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...sts/0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...fests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...s/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...ted.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions .../0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions machineconfiguration/v1/zz_generated.featuregated-crd-manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,12 @@ machineconfignodes.machineconfiguration.openshift.io:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...ifests/machineconfignodes.machineconfiguration.openshift.io/ImageModeStatusReporting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...sts/machineconfignodes.machineconfiguration.openshift.io/IrreconcilableMachineConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...rd-manifests/machineconfignodes.machineconfiguration.openshift.io/MachineConfigNodes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...ifests/machineconfignodes.machineconfiguration.openshift.io/NoRegistryClusterInstall.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...sts/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...d-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...crds/0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...rds/0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions .../crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...anifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...s/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions ...ad-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down
8 changes: 6 additions & 2 deletions .../0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ spec:
name: Resumed
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFilesAndOS")].status
name: UpdatedFilesAndOS
- jsonPath: .status.conditions[?(@.type=="AppliedOSImage")].status
name: AppliedOSImage
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="AppliedFiles")].status
name: AppliedFiles
priority: 1
type: string
- jsonPath: .status.conditions[?(@.type=="Cordoned")].status
Expand Down