Skip to content

MCO-1931: Promote ManagedBootImagesCPMS feature gate to the Default featureset #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Feb 3, 2026
Merged

MCO-1931: Promote ManagedBootImagesCPMS feature gate to the Default featureset #2679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
| IrreconcilableMachineConfig| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| KMSEncryption| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| MachineAPIMigration| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ManagedBootImagesCPMS| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| MaxUnavailableStatefulSet| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| MinimumKubeletVersion| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| MixedCPUsAllocation| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down Expand Up @@ -98,6 +97,7 @@
| ManagedBootImages| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ManagedBootImagesAWS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ManagedBootImagesAzure| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ManagedBootImagesCPMS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Copy link

@coderabbitai coderabbitai bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix MD060 table pipe spacing on this row.

Line 100 violates the configured table column style. Please normalize the spacing around the pipe after the feature name to match the table’s configured style.

🧹 Suggested spacing fix 
-| ManagedBootImagesCPMS| <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span>  |
+| ManagedBootImagesCPMS | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span>  |
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
| ManagedBootImagesCPMS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ManagedBootImagesCPMS | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> | <span style="background-color: `#519450`">Enabled</span> |
🧰 Tools
🪛 markdownlint-cli2 (0.20.0)

100-100: Table column style
Table pipe is missing space to the left for style "compact"

(MD060, table-column-style)

100-100: Table column style
Table pipe has extra space to the left for style "compact"

(MD060, table-column-style)

🤖 Prompt for AI Agents 
In `@features.md` at line 100, The table row for feature ManagedBootImagesCPMS
violates MD060 spacing around pipes; edit the row so there is a single space
between the feature name and the following pipe (i.e., change
"ManagedBootImagesCPMS|" to "ManagedBootImagesCPMS |") and ensure spacing around
all pipes in that row matches the table's configured style (one space on each
side).

| ManagedBootImagesvSphere| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| MetricsCollectionProfiles| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| NetworkDiagnosticsConfig| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
2 changes: 1 addition & 1 deletion features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ var (
contactPerson("djoshy").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1818").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
enableIn(configv1.Default, configv1.OKD, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateBootImageSkewEnforcement = newFeatureGate("BootImageSkewEnforcement").
Expand Down
12 changes: 12 additions & 0 deletions ..._generated.crd-manifests/0000_80_machine-config_01_machineconfigurations-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -197,6 +198,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down Expand Up @@ -741,6 +747,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -830,6 +837,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down
12 changes: 12 additions & 0 deletions ...1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfigurations-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -197,6 +198,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down Expand Up @@ -741,6 +747,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -830,6 +837,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down
12 changes: 12 additions & 0 deletions payload-manifests/crds/0000_80_machine-config_01_machineconfigurations-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -197,6 +198,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down Expand Up @@ -741,6 +747,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -830,6 +837,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down
12 changes: 12 additions & 0 deletions payload-manifests/crds/0000_80_machine-config_01_machineconfigurations-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -197,6 +198,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down Expand Up @@ -741,6 +747,7 @@ spec:
controlplanemachinesets means that the machine manager will only register resources of the kind ControlPlaneMachineSet.
enum:
- machinesets
- controlplanemachinesets
type: string
selection:
description: selection allows granular control of the machine
Expand Down Expand Up @@ -830,6 +837,11 @@ spec:
- resource
- selection
type: object
x-kubernetes-validations:
- message: Only All or None selection mode is permitted for
ControlPlaneMachineSets
rule: self.resource != 'controlplanemachinesets' || self.selection.mode
== 'All' || self.selection.mode == 'None'
maxItems: 5
type: array
x-kubernetes-list-map-keys:
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@
{
"name": "MachineAPIOperatorDisableMachineHealthCheckController"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "MaxUnavailableStatefulSet"
},
Expand Down Expand Up @@ -308,6 +305,9 @@
{
"name": "ManagedBootImagesAzure"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "ManagedBootImagesvSphere"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,6 @@
{
"name": "MachineAPIOperatorDisableMachineHealthCheckController"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "MaxUnavailableStatefulSet"
},
Expand Down Expand Up @@ -310,6 +307,9 @@
{
"name": "ManagedBootImagesAzure"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "ManagedBootImagesvSphere"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,6 @@
{
"name": "MachineAPIOperatorDisableMachineHealthCheckController"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "MaxUnavailableStatefulSet"
},
Expand Down Expand Up @@ -299,6 +296,9 @@
{
"name": "ManagedBootImagesAzure"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "ManagedBootImagesvSphere"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,6 @@
{
"name": "MachineAPIOperatorDisableMachineHealthCheckController"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "MaxUnavailableStatefulSet"
},
Expand Down Expand Up @@ -301,6 +298,9 @@
{
"name": "ManagedBootImagesAzure"
},
{
"name": "ManagedBootImagesCPMS"
},
{
"name": "ManagedBootImagesvSphere"
},
Expand Down