AGENT-1426: Use localhost for registry domain in interactive flow#645
AGENT-1426: Use localhost for registry domain in interactive flow#645danielerez wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@danielerez: This pull request references AGENT-1426 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
danielerez
force-pushed
the
support-interactive-flow-localhost-registry
branch
from
8dc40fc to
26d5f6f
Compare
When EnableInteractiveFlow is enabled, configure registry mirrors and oc-mirror output to use localhost instead of the default registry domain. This is needed to avoid any suprious entries in registries.conf file. Changes: - Update generateRegistries to accept enableInteractiveFlow parameter - Use localhost when interactive flow is enabled for registry mirrors - Update copyOutputYamls to use localhost registry domain in interactive flow - Add swag import for boolean value handling
danielerez
force-pushed
the
support-interactive-flow-localhost-registry
branch
from
26d5f6f to
d0c1259
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@danielerez I'd like to land first openshift/release#75449 (and all of its dependencies) to have a more consolidated ways to test OVE related patches (now that we've got a fully working CI job) |
ack. |
| if swag.BoolValue(enableInteractiveFlow) { | ||
| r.Mirrors = append(r.Mirrors, sysregistriesv2.Endpoint{ | ||
| Location: re.ReplaceAllString(m, fmt.Sprintf("%s:%d", "localhost", RegistryPort)), | ||
| }) |
There was a problem hiding this comment.
Wondering why a corresponding entry for RegistryPortUpgrade did not need to be added here.
There was a problem hiding this comment.
We don't use that appliance feature
I think it'd safe to handle it just afterwards. We can test it once the CI job will be available |
|
/pj-rehearse ? |
|
/test ? |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
1 similar comment
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
@danielerez: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
When EnableInteractiveFlow is enabled, configure registry mirrors and oc-mirror output to use localhost instead of the default registry domain. This is needed to avoid any suprious entries in registries.conf file.
Changes: