Skip to content

OCPBUGS-78250: Append interactive flow ignition to Bootstrap config#670

Open
danielerez wants to merge 1 commit intoopenshift:masterfrom
danielerez:move-interactive-ign-to-bootstrap
Open

OCPBUGS-78250: Append interactive flow ignition to Bootstrap config#670
danielerez wants to merge 1 commit intoopenshift:masterfrom
danielerez:move-interactive-ign-to-bootstrap

Conversation

@danielerez
Copy link
Contributor

When EnableInteractiveFlow is true, interactive flow files (interactive-ui, no-config-image, internalreleaseimage.yaml) are now appended to bootstrapIgnition.Config rather than unconfiguredIgnition.
Added unit tests that verify this behavior by asserting interactive flow content ends up in Bootstrap but not in Unconfigured.

When EnableInteractiveFlow is true, interactive flow files (interactive-ui,
no-config-image, internalreleaseimage.yaml) are now appended to
bootstrapIgnition.Config rather than unconfiguredIgnition.

Added unit tests that verify this behavior by asserting interactive flow
content ends up in Bootstrap but not in Unconfigured.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 12, 2026
@openshift-ci-robot
Copy link

@danielerez: This pull request references Jira Issue OCPBUGS-78250, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When EnableInteractiveFlow is true, interactive flow files (interactive-ui, no-config-image, internalreleaseimage.yaml) are now appended to bootstrapIgnition.Config rather than unconfiguredIgnition.
Added unit tests that verify this behavior by asserting interactive flow content ends up in Bootstrap but not in Unconfigured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mhanss March 12, 2026 16:20
@danielerez danielerez requested review from andfasano, omer-vishlitzky and pawanpinjarkar and removed request for mhanss March 12, 2026 16:20
@danielerez
Copy link
Contributor Author

Haven't tested yet. help would be appreciated:)

@openshift-ci openshift-ci bot requested review from avishayt and gamli75 March 12, 2026 16:22
@openshift-ci
Copy link

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026
@pawanpinjarkar
Copy link
Contributor

/lgtm

@pawanpinjarkar
Copy link
Contributor

/cherrypick release-4.21

@openshift-cherrypick-robot

@pawanpinjarkar: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2026
@andfasano
Copy link
Contributor

/hold

Let's check first that ci/prow/e2e-agent-compact-ipv4-iso-no-registry completes successfully

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 12, 2026

@danielerez: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants