OCPBUGS-78250: Append interactive flow ignition to Bootstrap config#670
OCPBUGS-78250: Append interactive flow ignition to Bootstrap config#670danielerez wants to merge 1 commit intoopenshift:masterfrom
Conversation
When EnableInteractiveFlow is true, interactive flow files (interactive-ui, no-config-image, internalreleaseimage.yaml) are now appended to bootstrapIgnition.Config rather than unconfiguredIgnition. Added unit tests that verify this behavior by asserting interactive flow content ends up in Bootstrap but not in Unconfigured.
|
@danielerez: This pull request references Jira Issue OCPBUGS-78250, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Haven't tested yet. help would be appreciated:) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/cherrypick release-4.21 |
|
@pawanpinjarkar: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Let's check first that ci/prow/e2e-agent-compact-ipv4-iso-no-registry completes successfully |
|
@danielerez: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When EnableInteractiveFlow is true, interactive flow files (interactive-ui, no-config-image, internalreleaseimage.yaml) are now appended to bootstrapIgnition.Config rather than unconfiguredIgnition.
Added unit tests that verify this behavior by asserting interactive flow content ends up in Bootstrap but not in Unconfigured.