added fedramp specific PKO templates#372
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fsferraz-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (4)
WalkthroughAdds two OpenShift Template manifests that render a templated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hack/pko/clusterpackage-fedramp-hive.yaml`:
- Around line 13-14: The template defines parameters IMAGE_DIGEST and NAMESPACE
that are unused: either remove the IMAGE_DIGEST and NAMESPACE parameter entries
or wire NAMESPACE into the CredentialsRequest resources instead of the hardcoded
openshift-${REPO_NAME}; also remove the required: true flag from IMAGE_DIGEST if
you keep it but leave it optional. Locate the parameter block (IMAGE_DIGEST,
NAMESPACE) and the CredentialsRequest resource definitions (references to
openshift-${REPO_NAME}) and either delete the unused parameter(s) or replace the
hardcoded namespace with ${NAMESPACE} and ensure IMAGE_DIGEST is referenced
where intended or its required flag removed.
In `@hack/pko/clusterpackage-fedramp.yaml`:
- Around line 7-12: The parameters CHANNEL and IMAGE_DIGEST are declared with
required: true but not used; remove or make them optional, or wire them into the
template where images are defined. Either delete the CHANNEL and IMAGE_DIGEST
parameter blocks (or set required: false) or update the image template
references (e.g., replace image references that currently use IMAGE_TAG with a
digest form like ${PKO_IMAGE}@${IMAGE_DIGEST} or incorporate ${CHANNEL} into
image names/tags) so the declared symbols CHANNEL and IMAGE_DIGEST are actually
referenced by the template objects.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3d4d83a3-9ac4-4279-9621-a5508d45ee52
📒 Files selected for processing (2)
hack/pko/clusterpackage-fedramp-hive.yamlhack/pko/clusterpackage-fedramp.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 40.69% 40.69%
=======================================
Files 32 32
Lines 2106 2106
=======================================
Hits 857 857
Misses 1145 1145
Partials 104 104 🚀 New features to boost your workflow:
|
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hack/pko/clusterpackage-fedramp.yaml`:
- Around line 141-145: The ConfigMap resource "avo-config" currently hardcodes
the namespace "openshift-aws-vpce-operator"; change it to use the template
parameter (e.g. ${REPO_NAME}) so the namespace follows the rest of the package
parameterization. Locate the "kind: ConfigMap" block for avo-config and replace
the literal namespace value with the repository namespace variable used
elsewhere in this YAML/template so the ConfigMap lands in the correct namespace
when REPO_NAME is overridden.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a82f260f-b00c-407b-94db-f8a32f256eb3
📒 Files selected for processing (3)
hack/olm-registry/olm-artifacts-template.yamlhack/pko/clusterpackage-fedramp-hive.yamlhack/pko/clusterpackage-fedramp.yaml
|
/retest-required |
|
@fsferraz-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
added fedramp specific PKO templates
HCMSEC-2912
Summary by CodeRabbit
New Features
Chores