Skip to content

OCPBUGS-83863: Remove rhel8 build stage, strip debug info #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdodson wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −8
Open

OCPBUGS-83863: Remove rhel8 build stage, strip debug info #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7b143f
Remove rhel8 build stage from Dockerfile.openshift
sdodson Apr 28, 2026
2ba8bc5
Strip debug symbols from the bond binary
sdodson Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Dockerfile.openshift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,9 @@ WORKDIR /go/src/github.com/openshift/bond-cni
COPY . .
RUN ./build.sh

FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.26-openshift-5.0 AS rhel8
WORKDIR /go/src/github.com/openshift/bond-cni
COPY . .
RUN ./build.sh

FROM registry.ci.openshift.org/ocp/5.0:base-rhel9
LABEL io.k8s.display-name="bond-cni" \
io.k8s.description="This is an image containing the bond-cni executable" \
io.openshift.tags="openshift"

COPY --from=rhel9 /go/src/github.com/openshift/bond-cni/bin/bond /bondcni/rhel9/bond
COPY --from=rhel9 /go/src/github.com/openshift/bond-cni/bin/bond /bondcni/bond
COPY --from=rhel8 /go/src/github.com/openshift/bond-cni/bin/bond /bondcni/rhel8/bond
2 changes: 1 addition & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ set -e
echo "Building bond-cni plugins"

export GO111MODULE=on
go build --mod=vendor -o ./bin/bond ./bond/
go build --mod=vendor -ldflags '-s -w' -o ./bin/bond ./bond/

@karampok karampok Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build.sh is planned to be removed since is single line and if changed we should be change upstream (https://github.com/k8snetworkplumbingwg/bond-cni).
So for this PR can you make no changes here and simply replace the RUN ./build.sh in the Dockerfile.openshift instead?