DPTP-4077: Always run post steps on cancellation to prevent resource leaks

[deepsm007]

/cc @openshift/test-platform

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@deepsm007: This pull request references DPTP-4077 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/cc @openshift/test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Adds phase tracking to multi-stage test execution: new exported label constant, a phase field on pod-generation options that labels created Pods when set, and a refactored Run flow that records pre/test errors separately, detects cancellation during pre/test, and guarantees post-phase execution (using background context when cancelled).

Changes

Cohort / File(s)	Summary
Phase-aware pod generation pkg/steps/multi_stage/gen.go, pkg/steps/multi_stage/run.go	Added optional phase string to generatePodOptions and pass it from run logic; when non-empty, generated Pods are labeled with MultiStageTestPhaseLabel. Also added synchronization (s.subLock) when appending s.subTests.
Phase tracking and execution flow pkg/steps/multi_stage/multi_stage.go	Added exported constant MultiStageTestPhaseLabel = "ci.openshift.io/multi-stage-test-phase". Refactored Run to separate pre/test error capture, detect cancellation during pre/test phases, and ensure post runs unconditionally (using background context if cancelled), with adjusted logging and aggregated errors.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hector-vido]

/lgtm

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@pkg/steps/multi_stage/multi_stage.go`:
- Around line 248-288: The post steps always use context.Background() which
ignores job deadlines/cancellation; change postCtx to use the original ctx by
default and only switch to context.Background() when cancelledDuringPreOrTest is
true: set postCtx := ctx, and if cancelledDuringPreOrTest then set postCtx =
context.Background(); then call s.runSteps(postCtx, "post", s.post, ...) so post
steps respect the original deadline/cancellation unless a prior cancellation
occurred. Ensure this change is applied around the existing
cancelledDuringPreOrTest, postCtx, and runSteps usage (refer to
cancelledDuringPreOrTest, postCtx, runSteps, cancelObserversContext, s.name).

[hector-vido]

/lgtm

[deepsm007]

/hold

[deepsm007]

/unhold

[openshift-ci-robot]

Scheduling required tests:
/test e2e

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, hector-vido, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deepsm007,hector-vido,liangxia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4188be3 and 2 for PR HEAD aafadc2 in total

[deepsm007]

/hold

[openshift-ci]

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/breaking-changes	aafadc2	link	false	/test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[petr-muller]

/cc