OCPNODE-4383: WIP: 4.22: require admin ack from 4.21 to 4.22 if runc is present#9161
OCPNODE-4383: WIP: 4.22: require admin ack from 4.21 to 4.22 if runc is present#9161haircommander wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@haircommander: This pull request references OCPNODE-4383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughA new blocked-edge rule configuration file is added for version 4.22.0 that detects deprecated runc container runtime usage and recommends migration to crun before upgrading, with PromQL-based matching rules. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
btw: engineering is still discussing whether to take this approach, hence the WIP, but I wanted to put it together so we can work through any issues with the recommendation in parallel |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@blocked-edges/4.22.0-RuncDeprecatedUpgradeRecommendation.yaml`:
- Line 3: The metadata uses OCPNODE-4382 in the URL and another location but the
change should reference OCPNODE-4383; update the string
"https://redhat.atlassian.net/browse/OCPNODE-4382" and any other occurrences of
"OCPNODE-4382" in this file to "OCPNODE-4383" so the Jira ID is consistent
(check both the url line and the second occurrence noted in the comment).
- Line 2: The rule currently uses a broad source regex "from: .*" which applies
the risk to all upgrade sources; update the "from:" value in
blocked-edges/4.22.0-RuncDeprecatedUpgradeRecommendation.yaml to narrowly match
only 4.21 patch versions (for example use a regex like ^4\.21\.\d+$) so the gate
applies only to 4.21→4.22 upgrades and does not affect other upgrade paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: a138e7cb-939c-41ce-82f5-635732be1bd5
📒 Files selected for processing (1)
blocked-edges/4.22.0-RuncDeprecatedUpgradeRecommendation.yaml
| @@ -0,0 +1,21 @@ | |||
| to: 4.22.0 | |||
| from: .* | |||
There was a problem hiding this comment.
Restrict source-version scope to 4.21.x upgrades
from: .* on Line 2 applies this risk to all upgrade sources, but this PR is scoped to 4.21 → 4.22. Please narrow the regex to 4.21.z so unrelated upgrade paths don’t get admin-ack gated.
Proposed change
-from: .*
+from: ^4\.21\..*$📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| from: .* | |
| from: ^4\.21\..*$ |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@blocked-edges/4.22.0-RuncDeprecatedUpgradeRecommendation.yaml` at line 2, The
rule currently uses a broad source regex "from: .*" which applies the risk to
all upgrade sources; update the "from:" value in
blocked-edges/4.22.0-RuncDeprecatedUpgradeRecommendation.yaml to narrowly match
only 4.21 patch versions (for example use a regex like ^4\.21\.\d+$) so the gate
applies only to 4.21→4.22 upgrades and does not affect other upgrade paths.
| @@ -0,0 +1,21 @@ | |||
| to: 4.22.0 | |||
| from: .* | |||
| url: https://redhat.atlassian.net/browse/OCPNODE-4382 | |||
There was a problem hiding this comment.
Use the PR’s Jira ID consistently in metadata
Lines 3 and 6 point to OCPNODE-4382, while this change is tracked as OCPNODE-4383. Keeping these aligned is important for risk provenance and lifecycle tooling.
Also applies to: 6-6
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@blocked-edges/4.22.0-RuncDeprecatedUpgradeRecommendation.yaml` at line 3, The
metadata uses OCPNODE-4382 in the URL and another location but the change should
reference OCPNODE-4383; update the string
"https://redhat.atlassian.net/browse/OCPNODE-4382" and any other occurrences of
"OCPNODE-4382" in this file to "OCPNODE-4383" so the Jira ID is consistent
(check both the url line and the second occurrence noted in the comment).
Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
runc-blocked
branch
from
246aa4c to
5f0526a
Compare
|
@haircommander: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close |
|
@haircommander: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
assisted by Claude