OCPBUGS-78227: [release-4.16] update go mod dependency for konflux#591
OCPBUGS-78227: [release-4.16] update go mod dependency for konflux#591fgallott wants to merge 3 commits intoopenshift:release-4.16from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
fgallott
changed the title
Two issues prevent upstream unit tests from passing in OpenShift CI: 1. CRD path resolution fails with vendoring. The upstream repo does not vendor, so `go test` uses module mode and downloads full module sources (including non-Go assets like CRD YAMLs) to $GOPATH/pkg/mod. The OpenShift fork vendors dependencies, and Go 1.14+ defaults to -mod=vendor when a vendor/ directory is present. Vendor directories only contain Go source files, so the cluster-api CRD YAMLs at $GOPATH/pkg/mod/sigs.k8s.io/cluster-api@.../config/crd/bases are never downloaded, causing test helpers to panic. Fix: explicitly set GOFLAGS=-mod=mod in unit-tests.sh to force module mode, matching upstream behaviour. 2. TestGetManagerNamespace fails due to mounted service account. GetManagerNamespace() reads /var/run/secrets/.../namespace before falling back to the POD_NAMESPACE env var. Upstream Prow runs tests on an EKS cluster where service account tokens are not automounted, so the file does not exist and the env var path is exercised. OpenShift CI (ci-operator) creates test pods with service accounts mounted, so the file exists and returns the CI namespace (ci-op-*) regardless of the env var the test sets. Fix: change inClusterNamespacePath from const to var so the test can override it, ensuring the env var fallback path is exercised in any CI environment. Additionally aligns unit-tests.sh with upstream scripts/ci-test.sh: source hack/ensure-go.sh and use make test-verbose. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
New changes are detected. LGTM label has been removed. |
|
@fgallott: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira cherrypick OCPBUGS-78175 |
|
@fgallott: Jira Issue OCPBUGS-78175 has been cloned as Jira Issue OCPBUGS-78227. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@fgallott: This pull request references Jira Issue OCPBUGS-78227, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. |
5 participants
cherry pick of e234161, #545
same as #590