[WIP] CNTRLPLANE-3234: health reporter writer (with typed client) #929
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package kmshealthwriter | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| applyoperatorv1 "github.com/openshift/client-go/operator/applyconfigurations/operator/v1" | ||
| operatorclient "github.com/openshift/client-go/operator/clientset/versioned" | ||
| "github.com/openshift/library-go/pkg/operator/encryption/kms/health" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/rest" | ||
| ) | ||
|
|
||
| // NewEncryptionStatusWriter satisfies health.NewEncryptionStatusWriterFunc. | ||
| // Only the operator itself knows where to apply the KMSEncryptionStatus. | ||
| func NewEncryptionStatusWriter(restConfig *rest.Config, fieldManager string) (health.EncryptionStatusWriter, error) { | ||
| client, err := operatorclient.NewForConfig(restConfig) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return func(ctx context.Context, status *applyoperatorv1.KMSEncryptionStatusApplyConfiguration) error { | ||
|
Member
There was a problem hiding this comment. This mechanism sounds like a good idea to me |
||
| _, err := client.OperatorV1().Authentications().ApplyStatus( | ||
| ctx, | ||
| applyoperatorv1.Authentication("cluster"). | ||
| WithStatus(applyoperatorv1.AuthenticationStatus().WithOAuthAPIServer( | ||
| applyoperatorv1.OAuthAPIServerStatus().WithEncryptionStatus(status), | ||
| )), | ||
| metav1.ApplyOptions{FieldManager: fieldManager, Force: true}, | ||
| ) | ||
| return err | ||
| }, nil | ||
| } | ||
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🔴 Critical
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/cluster-authentication-operator
Length of output: 340
Remove the machine-local
replacedirective before merge.Line 137 pins
github.com/openshift/library-goto an absolute workstation path (/home/ibihim/...), which breaks builds on other machines and CI systems lacking that exact path. This violates supply chain security requirements for reproducible dependency resolution.Suggested fix
-replace github.com/openshift/library-go => /home/ibihim/go/src/github.com/openshift/library-go-worktrees/CNTRLPLANE-3234-health-reporter-writerIf local development requires this replace, move it to
go.workinstead.📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Path instructions