OCPBUGS-87480: Updating ose-cluster-authentication-operator-container image to be consistent with ART for 5.0#934
Conversation
|
@liouk: This pull request references Jira Issue OCPBUGS-87480, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe Go toolchain directive, CI build root image tag, and Dockerfile base images were updated from Go 1.25 / OpenShift 4.22 to Go 1.26 / OpenShift 5.0. ChangesGo 1.26 build and image updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@liouk: This pull request references Jira Issue OCPBUGS-87480, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Dockerfile.rhel7 (1)
11-16: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick winSet an explicit non-root
USERin the final stage.The runtime image still defaults to root, which keeps the operator unnecessarily privileged. Add a non-root user before
ENTRYPOINTand make sure the copied files remain readable.As per path instructions, "USER non-root; never run as root".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile.rhel7` around lines 11 - 16, The final stage in Dockerfile.rhel7 still runs as root, so add an explicit non-root USER before ENTRYPOINT and keep the copied binaries and manifests readable/executable for that user. Update the final runtime stage that starts from the base image to switch away from root using a standard non-root account, and verify the COPY targets used by authentication-operator and cluster-authentication-operator-tests-ext.gz remain accessible after the change.Sources: Path instructions, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Dockerfile.rhel7`:
- Around line 11-16: The final stage in Dockerfile.rhel7 still runs as root, so
add an explicit non-root USER before ENTRYPOINT and keep the copied binaries and
manifests readable/executable for that user. Update the final runtime stage that
starts from the base image to switch away from root using a standard non-root
account, and verify the COPY targets used by authentication-operator and
cluster-authentication-operator-tests-ext.gz remain accessible after the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e514e0be-2a7f-4347-b447-fdb041a017b3
📒 Files selected for processing (3)
.ci-operator.yamlDockerfile.rhel7go.mod
|
/retest-required |
|
@liouk: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.25-openshift-4.22 | ||
| tag: rhel-9-release-golang-1.26-openshift-5.0 |
There was a problem hiding this comment.
I might be wrong, but does OpenShift 5.0 run with RHEL 10?
There was a problem hiding this comment.
AFAIU, this refers to the CI environment that will build the operator -- I don't see why RHEL 10 wouldn't work but I'm guessing that the ART haven't transitioned fully to 10.
This was taken as-is from the automated ART PR: https://github.com/openshift/cluster-authentication-operator/pull/910/changes
|
/lgtm |
Replaces #910
Summary by CodeRabbit