[WIP] CNTRLPLANE-3234: Use health reporter

[ibihim]

What

Use health reporter as given in this PR.

Why

Testing integration / that the library-go PR actually works.

Summary by CodeRabbit

• Bug Fixes
  • Improved the authentication operator’s KMS health check so it now uses a working authentication writer, helping health reporting behave correctly.

[openshift-ci-robot]

@ibihim: This pull request references CNTRLPLANE-3234 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What

Use health reporter as given in this PR.

Why

Testing integration / that the library-go PR actually works.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d5277675-ed2e-49d9-983e-228820bba831

📥 Commits

Reviewing files that changed from the base of the PR and between 60f4dee and 89d76b3.

⛔ Files ignored due to path filters (6)

• go.sum is excluded by !**/*.sum
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/health/cmd.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/health/options.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/health/prober.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/health/writers/writers.go is excluded by !**/vendor/**, !vendor/**
• vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (2)

• cmd/authentication-operator/main.go
• go.mod

---

Walkthrough

NewAuthenticationOperatorCommand replaces a TODO stub (that returned a nil operator client) with kmshealth.NewCommand configured using writers.NewAuthenticationWriter. The v1helpers import is removed and the writers package is added. A temporary go.mod replace directive pins github.com/openshift/library-go to a fork.

Changes

KMS Health Writer Wiring

Layer / File(s)	Summary
Replace stub with writers.NewAuthenticationWriter cmd/authentication-operator/main.go	Removes the v1helpers import and TODO stub; adds the writers package import and passes writers.NewAuthenticationWriter to kmshealth.NewCommand.
Temporary library-go fork pin go.mod	Adds a replace directive overriding github.com/openshift/library-go with github.com/ibihim/library-go at a specific commit, with comments to remove it after upstream merges.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: wiring in the health reporter for CNTRLPLANE-3234.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only main.go and go.mod changed; no Ginkgo specs or test titles were added or modified, so there are no dynamic test names to flag.
Test Structure And Quality	✅ Passed	No Ginkgo test code was changed; this commit only rewires the health reporter in cmd/authentication-operator/main.go.
Microshift Test Compatibility	✅ Passed	Touched code only wires a command and pins library-go; no Ginkgo tests or MicroShift-sensitive test APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; changes only wire KMS health command and a go.mod replace, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Changed files only add a CLI health command and a library-go pin; no manifests, replicas, affinities, nodeSelectors, or topology-aware scheduling logic were introduced.
Ote Binary Stdout Contract	✅ Passed	No new process-level stdout writes were added; the health command logs via klog/cli.InitLogs (stderr), and the OTE entrypoint already calls klog.LogToStderr(true).
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes command wiring and go.mod; no new Ginkgo specs or network code were added, so IPv6/disconnected compatibility is not applicable.
No-Weak-Crypto	✅ Passed	PR only wires a KMS health command and adds a library-go replace; no weak ciphers, custom crypto, or token comparisons appear in the changed code.
Container-Privileges	✅ Passed	Only CLI wiring and go.mod changed; no container/K8s manifest additions with privileged, hostPID/Network/IPC, SYS_ADMIN, runAsUser: 0, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs	✅ Passed	Patch only rewires the KMS health command; no new log statements or sensitive-data strings appear in cmd/authentication-operator/main.go or go.mod.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator-encryption-perf	89d76b3	link	true	/test e2e-gcp-operator-encryption-perf
ci/prow/e2e-agnostic	89d76b3	link	true	/test e2e-agnostic

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.