Skip to content

[openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE#481

Closed
redhat-chai-bot wants to merge 1 commit into
openshift:release-4.22from
redhat-chai-bot:revert-480-OCPBUGS-92656
Closed

[openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE#481
redhat-chai-bot wants to merge 1 commit into
openshift:release-4.22from
redhat-chai-bot:revert-480-OCPBUGS-92656

Conversation

@redhat-chai-bot

Copy link
Copy Markdown

This reverts merge commit f622188 (PR #480) which broke 4.22 nightlies on metal platforms.

Root cause

The GetCloudConfig() call added in main.go invokes framework.LoadConfig() which initializes klog. On 4.22, klog writes INFO-level lines to stdout. When openshift-tests runs the OTE binary's list subcommand, it expects pure JSON on stdout but gets klog noise instead, causing invalid character 'I' looking for beginning of value errors.

This worked on 5.0 because OTE PR #74 makes openshift-tests-extension scan for the first { or [ line before unmarshalling, tolerating stdout contamination. The 4.22 branch uses an older openshift-tests-extension without this fix.

Failing jobs

  • metal-ipi-ovn-ipv4 (blocking)
  • metal-ipi-ovn-ipv6 (blocking)

See payload analysis for details.

A fix-forward PR will follow that re-lands the dualstack changes with an updated openshift-tests-extension dependency to resolve the klog/JSON parsing issue.

/cc @mtulio

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2026
@openshift-ci openshift-ci Bot requested a review from mtulio June 29, 2026 13:48
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-92656, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts merge commit f622188 (PR #480) which broke 4.22 nightlies on metal platforms.

Root cause

The GetCloudConfig() call added in main.go invokes framework.LoadConfig() which initializes klog. On 4.22, klog writes INFO-level lines to stdout. When openshift-tests runs the OTE binary's list subcommand, it expects pure JSON on stdout but gets klog noise instead, causing invalid character 'I' looking for beginning of value errors.

This worked on 5.0 because OTE PR #74 makes openshift-tests-extension scan for the first { or [ line before unmarshalling, tolerating stdout contamination. The 4.22 branch uses an older openshift-tests-extension without this fix.

Failing jobs

  • metal-ipi-ovn-ipv4 (blocking)
  • metal-ipi-ovn-ipv6 (blocking)

See payload analysis for details.

A fix-forward PR will follow that re-lands the dualstack changes with an updated openshift-tests-extension dependency to resolve the klog/JSON parsing issue.

/cc @mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 95380f5c-6339-4137-a858-7f2251180f25

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mdbooth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/retitle "[openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE"

@openshift-ci openshift-ci Bot changed the title Revert "Bug OCPBUGS-92656: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE" "[openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE" Jun 29, 2026
@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/retitle [openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE

@openshift-ci openshift-ci Bot changed the title "[openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE" [openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE Jun 29, 2026
@mtulio

mtulio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Fix proposal is in progress at #482 , if there is green we prefer there than reverting changes.
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam stbenjam closed this Jun 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-92656. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts merge commit f622188 (PR #480) which broke 4.22 nightlies on metal platforms.

Root cause

The GetCloudConfig() call added in main.go invokes framework.LoadConfig() which initializes klog. On 4.22, klog writes INFO-level lines to stdout. When openshift-tests runs the OTE binary's list subcommand, it expects pure JSON on stdout but gets klog noise instead, causing invalid character 'I' looking for beginning of value errors.

This worked on 5.0 because OTE PR #74 makes openshift-tests-extension scan for the first { or [ line before unmarshalling, tolerating stdout contamination. The 4.22 branch uses an older openshift-tests-extension without this fix.

Failing jobs

  • metal-ipi-ovn-ipv4 (blocking)
  • metal-ipi-ovn-ipv6 (blocking)

See payload analysis for details.

A fix-forward PR will follow that re-lands the dualstack changes with an updated openshift-tests-extension dependency to resolve the klog/JSON parsing issue.

/cc @mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants