[openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE#481
Conversation
…tream test skips to 4.22 OTE"
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-92656, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retitle "[openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE" |
|
/retitle [openshift-4.22] OCPBUGS-92656: revert: backport dual-stack IPFamilyPolicy and upstream test skips to 4.22 OTE |
|
Fix proposal is in progress at #482 , if there is green we prefer there than reverting changes. |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-92656. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This reverts merge commit f622188 (PR #480) which broke 4.22 nightlies on metal platforms.
Root cause
The
GetCloudConfig()call added inmain.goinvokesframework.LoadConfig()which initializes klog. On 4.22, klog writes INFO-level lines to stdout. Whenopenshift-testsruns the OTE binary'slistsubcommand, it expects pure JSON on stdout but gets klog noise instead, causinginvalid character 'I' looking for beginning of valueerrors.This worked on 5.0 because OTE PR #74 makes
openshift-tests-extensionscan for the first{or[line before unmarshalling, tolerating stdout contamination. The 4.22 branch uses an olderopenshift-tests-extensionwithout this fix.Failing jobs
metal-ipi-ovn-ipv4(blocking)metal-ipi-ovn-ipv6(blocking)See payload analysis for details.
A fix-forward PR will follow that re-lands the dualstack changes with an updated
openshift-tests-extensiondependency to resolve the klog/JSON parsing issue./cc @mtulio