OCPCLOUD-3347: tls: use centralized TLS profile (unrevert)

[damdo]

Unrevert of the revert #291, to reintroduce #286

--

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

[openshift-ci-robot]

@damdo: This pull request references OCPCLOUD-3347 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Unrevert of the revert #291, to reintroduce #286

--

Start using centralized TLS profile fetched from the APIServer configuration.
Remove kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/hold

For HCP to sort out the RBAC permission issue

[damdo]

/cc @neisw @bryan-cox

[damdo]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sjenning]

/hold

until the hypershift presubmit jobs are in place openshift/release#75309

[damdo]

/retest

[damdo]

/testwith openshift/cluster-machine-approver/main/e2e-hypershift-aks openshift/hypershift#7802

[damdo]

/testwith openshift/cluster-machine-approver/main/e2e-hypershift-aws openshift/hypershift#7802

[openshift-ci]

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-aws	357265a	link	true	/test e2e-hypershift-aws
ci/prow/e2e-aws-capi-techpreview	357265a	link	true	/test e2e-aws-capi-techpreview
ci/prow/e2e-hypershift-aks	357265a	link	true	/test e2e-hypershift-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sjenning]

Seems it is still failing

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-machine-approver/292/pull-ci-openshift-cluster-machine-approver-main-e2e-hypershift-aws/2026910449928245248/artifacts/e2e-hypershift-aws/hypershift-aws-run-e2e-external/artifacts/TestCreateCluster/namespaces/e2e-clusters-mn452-create-cluster-bxhgg/core/pods/logs/machine-approver-75cf8896f4-6tr6c-machine-approver-previous.log

F0226 07:08:51.113286       1 main.go:161] unable to get TLS profile from API server: failed to get APIServer "/cluster": apiservers.config.openshift.io "cluster" not found

[jmencak]

Seems it is still failing

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-machine-approver/292/pull-ci-openshift-cluster-machine-approver-main-e2e-hypershift-aws/2026910449928245248/artifacts/e2e-hypershift-aws/hypershift-aws-run-e2e-external/artifacts/TestCreateCluster/namespaces/e2e-clusters-mn452-create-cluster-bxhgg/core/pods/logs/machine-approver-75cf8896f4-6tr6c-machine-approver-previous.log

F0226 07:08:51.113286       1 main.go:161] unable to get TLS profile from API server: failed to get APIServer "/cluster": apiservers.config.openshift.io "cluster" not found

In HyperShift, shouldn't we be querying the HostedCluster object instead of the APIServer one? At least the enhancement seems to suggest that for SLOs.

Edit: Saying that, using APIServer object from the hosted cluster in HyperShift works just fine for my use case and the implementation is simpler than trying to find the HostedCluster object as suggested by the the enhancement.

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.