Skip to content

Add test/OWNERS file for proper code ownership#633

Open
wangke19 wants to merge 1 commit into
openshift:mainfrom
wangke19:add-test-owners
Open

Add test/OWNERS file for proper code ownership#633
wangke19 wants to merge 1 commit into
openshift:mainfrom
wangke19:add-test-owners

Conversation

@wangke19

@wangke19 wangke19 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR adds an OWNERS file for the test directory to ensure proper review and approval processes for test-related changes.

Details

  • Adds test/OWNERS with reviewers and approvers
  • Update OWNERS which removed names who have left.
  • Ensures proper code ownership for test infrastructure changes
  • Component: openshift-apiserver

Reviewers/Approvers

  • p0lyn0mial
  • benluddy
  • sanchezl
  • wangke19
  • gangwgr
  • xingxingxia

This PR is separated from the main OTE migration PR to get consensus on the OWNERS list before proceeding with the infrastructure changes.

@openshift-ci openshift-ci Bot requested review from deads2k and sanchezl December 1, 2025 09:33
@wangke19 wangke19 force-pushed the add-test-owners branch 2 times, most recently from 502071c to 211d42c Compare December 1, 2025 09:43
@wangke19

wangke19 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

@p0lyn0mial any updates?

@wangke19

wangke19 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

/assign @p0lyn0mial

Comment thread OWNERS Outdated
@openshift-ci

openshift-ci Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangke19
Once this PR has been reviewed and has the lgtm label, please ask for approval from p0lyn0mial. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This adds an OWNERS file for the test directory to ensure proper
review and approval processes for test-related changes.
@openshift-ci

openshift-ci Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment thread test/OWNERS
@openshift-bot

Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2026
@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 88e15654-c46d-4b19-890b-70a46a52c372

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2026
@openshift-ci

openshift-ci Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants