testing OTE job by bertinatto · Pull Request #694 · openshift/cluster-openshift-apiserver-operator

bertinatto · 2026-05-21T22:03:01Z

testing OTE job

Summary by CodeRabbit

Chores
- Updated a project dependency to a new version.

openshift-ci · 2026-05-21T22:03:06Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-05-21T22:03:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign flavianmissi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-05-21T22:03:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6c045b65-1428-4410-8854-0f5aaab7c46d

📥 Commits

Reviewing files that changed from the base of the PR and between df60399 and 2bea038.

⛔ Files ignored due to path filters (8)

go.sum is excluded by !**/*.sum
vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/config.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptiondata/secret.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/pluginlifecycle/sidecar.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/pluginlifecycle/vault.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.go is excluded by !**/vendor/**, !vendor/**
vendor/github.com/openshift/library-go/test/library/encryption/kms/vault.go is excluded by !**/vendor/**, !vendor/**
vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (1)

go.mod

✅ Files skipped from review due to trivial changes (1)

go.mod

Walkthrough

The go.mod module definition is updated with a version bump for the github.com/openshift/library-go dependency, changing the pseudo-version from ba2b9a3a3499 to d8750ed2813e. No other module metadata or direct dependencies are altered.

Changes

Dependency Update

Layer / File(s)	Summary
openshift/library-go version bump `go.mod`	The `github.com/openshift/library-go` dependency is bumped to a newer commit-based pseudo-version in the top-level `require` list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	7 new Ginkgo e2e tests for network policies lack SNO protection mechanisms (no [Skipped:SingleReplicaTopology], IsSingleNode checks, or similar guards).	Add [Skipped:SingleReplicaTopology] labels to test names in network_policy.go and network_policy_enforcement.go, or add IsSingleNode() checks to guard each test function from running on SNO clusters.
Title check	❓ Inconclusive	The title 'testing OTE job' is vague and does not clearly describe the actual change in the pull request, which is a dependency version bump in go.mod.	Revise the title to be more descriptive of the actual change, such as 'Bump github.com/openshift/library-go dependency version' to clarify what was modified.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies go.mod with library-go version bump; no test files or Ginkgo test definitions were changed, so the stable test names check is not applicable.
Test Structure And Quality	✅ Passed	Test code meets all requirements: single responsibility, cleanup with defer, timeouts in It blocks, assertion messages, consistent patterns.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added in this PR. The only changes were to go.mod/go.sum (dependency bump to library-go) and vendor files, which do not affect the MicroShift compatibility check criteria.
Topology-Aware Scheduling Compatibility	✅ Passed	PR is a dependency bump (library-go) only; no deployment manifests, operator code, or scheduling constraints were added/modified. Existing code is topology-aware.
Ote Binary Stdout Contract	✅ Passed	PR only updates go.mod (library-go bump). OTE main.go has no stdout violations: no fmt.Print in main(), init(), or top-level code; only fmt.Sprintf inside panic.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR reverts previous changes restoring pre-existing tests, not adding new ones. The custom check applies only to new tests. Restored Ginkgo tests properly support IPv6.
No-Weak-Crypto	✅ Passed	PR only updates go.mod dependency version; no weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto, or insecure secret comparisons found in application code (pkg/, cmd/).
Container-Privileges	✅ Passed	Privileged containers have explicit justification for audit logging; no hostPID/Network/IPC, SYS_ADMIN, or unwarranted privilege escalation found; operator uses non-root with restricted capabilities.
No-Sensitive-Data-In-Logs	✅ Passed	PR only updates go.mod dependency version for github.com/openshift/library-go. No new logging code was added; no passwords, tokens, API keys, PII, or sensitive data are logged in the changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 45: The Debugging section contains a leftover placeholder "testing..."
that should be removed or replaced with actionable guidance; open the README's
"Debugging" section, delete the "testing..." line (or replace it with a short,
useful instruction such as steps to reproduce, how to enable verbose logging, or
common troubleshooting commands), and ensure the section reads clearly without
placeholder text.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6f454d2f-d861-414b-85bc-a14a7f831cd4

📥 Commits

Reviewing files that changed from the base of the PR and between 6bdb9e9 and 165d858.

📒 Files selected for processing (1)

README.md

coderabbitai · 2026-05-21T22:05:57Z


 To gather all information necessary for debugging operator please use the [must-gather](https://github.com/openshift/must-gather) tool.
+
+testing...


⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove placeholder text from Debugging docs.

Line 45 (testing...) looks like leftover placeholder content and makes the section less clear for users. Please remove it or replace it with actionable debugging guidance.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 45, The Debugging section contains a leftover placeholder "testing..." that should be removed or replaced with actionable guidance; open the README's "Debugging" section, delete the "testing..." line (or replace it with a short, useful instruction such as steps to reproduce, how to enable verbose logging, or common troubleshooting commands), and ensure the section reads clearly without placeholder text.

bertinatto · 2026-05-21T22:13:37Z

/test e2e-gcp-operator-encryption-kms-ote

bertinatto · 2026-05-28T13:23:49Z

/test all

coderabbitai · 2026-05-28T13:25:44Z

Actionable comments posted: 0

bertinatto · 2026-05-28T14:37:18Z

/test e2e-gcp-operator-encryption-kms-ote

bertinatto · 2026-05-28T14:43:46Z

/test e2e-gcp-operator-encryption-kms

bertinatto · 2026-05-28T21:53:40Z

/test e2e-gcp-operator-encryption-kms

bertinatto · 2026-05-29T14:14:37Z

/test e2e-gcp-operator-encryption-kms

bertinatto · 2026-05-29T14:14:51Z

/test e2e-gcp-operator-encryption-kms-ote

openshift-ci · 2026-05-29T14:14:56Z

@bertinatto: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-operator

/test e2e-aws-ovn

/test e2e-upgrade

/test images

/test okd-scos-images

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-gcp-operator-encryption-aescbc

/test e2e-gcp-operator-encryption-aesgcm

/test e2e-gcp-operator-encryption-kms

/test e2e-gcp-operator-encryption-rotation-aescbc

/test e2e-gcp-operator-encryption-rotation-aesgcm

/test e2e-tests-extension

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-openshift-apiserver-operator-main-e2e-aws-operator

pull-ci-openshift-cluster-openshift-apiserver-operator-main-e2e-aws-ovn

pull-ci-openshift-cluster-openshift-apiserver-operator-main-e2e-upgrade

pull-ci-openshift-cluster-openshift-apiserver-operator-main-images

pull-ci-openshift-cluster-openshift-apiserver-operator-main-okd-scos-images

pull-ci-openshift-cluster-openshift-apiserver-operator-main-unit

pull-ci-openshift-cluster-openshift-apiserver-operator-main-verify

pull-ci-openshift-cluster-openshift-apiserver-operator-main-verify-deps

Details

In response to this:

/test e2e-gcp-operator-encryption-kms-ote

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-05-29T17:18:45Z

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator-encryption-kms-ote	`165d858`	link	false	`/test e2e-gcp-operator-encryption-kms-ote`
ci/prow/e2e-aws-ovn	`df60399`	link	true	`/test e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

…vault" This reverts commit ab20583, reversing changes made to e88ac2e.

…lifecycle-vault-credentials" This reverts commit e88ac2e, reversing changes made to d367670.

bertinatto · 2026-06-06T18:27:31Z

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview
/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview
/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-techpreview

openshift-ci · 2026-06-06T18:27:33Z

@bertinatto: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview
periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61b0efb0-61d5-11f1-9b41-42501d3d8c3f-0

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2026

coderabbitai Bot reviewed May 21, 2026

View reviewed changes

bertinatto force-pushed the test branch from 165d858 to 47ce26a Compare May 28, 2026 13:23

bertinatto marked this pull request as ready for review May 28, 2026 13:58

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2026

openshift-ci Bot requested review from everettraven and p0lyn0mial May 28, 2026 13:58

bertinatto force-pushed the test branch from 47ce26a to df60399 Compare May 29, 2026 12:04

tjungblu mentioned this pull request Jun 3, 2026

[Auto-Generated] KMS Team PR Dashboard openshift/library-go#2266

Closed

bertinatto added 2 commits June 6, 2026 14:25

Revert "Merge pull request openshift#704 from bertinatto/kms-ci-real-…

4f57cff

…vault" This reverts commit ab20583, reversing changes made to e88ac2e.

Revert "Merge pull request openshift#699 from bertinatto/kms-plugins-…

2bea038

…lifecycle-vault-credentials" This reverts commit e88ac2e, reversing changes made to d367670.

bertinatto force-pushed the test branch from df60399 to 2bea038 Compare June 6, 2026 18:26


		To gather all information necessary for debugging operator please use the [must-gather](https://github.com/openshift/must-gather) tool.

		testing...

Uh oh!

Conversation

bertinatto commented May 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented May 21, 2026

Uh oh!

openshift-ci Bot commented May 21, 2026

Uh oh!

coderabbitai Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

bertinatto commented May 21, 2026

Uh oh!

bertinatto commented May 28, 2026

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

bertinatto commented May 28, 2026

Uh oh!

bertinatto commented May 28, 2026

Uh oh!

bertinatto commented May 28, 2026

Uh oh!

bertinatto commented May 29, 2026

Uh oh!

bertinatto commented May 29, 2026

Uh oh!

openshift-ci Bot commented May 29, 2026

Uh oh!

openshift-ci Bot commented May 29, 2026

Uh oh!

bertinatto commented Jun 6, 2026

Uh oh!

openshift-ci Bot commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

bertinatto commented May 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 21, 2026 •

edited

Loading