-
Notifications
You must be signed in to change notification settings - Fork 670
CONSOLE-5015: Refactor file-input to use PF #15952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b242ead to
4f2d07b
Compare
01dbae5 to
7cfc3b6
Compare
- Remove `label`, `helpText`, `helpTextInvalid` from `FieldProps` because it's not common to all fields - Remove `hideContents` as a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a feature - Rename inputFieldHelpText prop to filenamePlaceholder for PF alignment - Align `co-required` style with PF
7cfc3b6 to
812b830
Compare
|
@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @rhamilto |
|
/label px-approved |
|
/assign @yapei |
|
@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
label,helpText,helpTextInvalidfromFieldPropsbecause it's not common to all fieldshideContentsas a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a featureco-requiredstyle with PFDroppableFileInputis now under the PF form ecosystem instead of the legacy one. That means that to useDroppableFileInputin a legacy form, you'll have to wrap it in apf-v6-c-formfor proper styling of the form group label