Skip to content

CONSOLE-5271: Use "life cycle" (two words) in operator lifecycle metadata UI strings#16684

Open
perdasilva wants to merge 1 commit into
openshift:mainfrom
perdasilva:CONSOLE-5271-lifecycle-to-life-cycle
Open

CONSOLE-5271: Use "life cycle" (two words) in operator lifecycle metadata UI strings#16684
perdasilva wants to merge 1 commit into
openshift:mainfrom
perdasilva:CONSOLE-5271-lifecycle-to-life-cycle

Conversation

@perdasilva

@perdasilva perdasilva commented Jun 29, 2026

Copy link
Copy Markdown

Analysis / Root cause:
Docs review feedback identified that user-facing strings in the operator lifecycle metadata UI should use "life cycle" (two words) and "life cycles" instead of "lifecycle" and "lifecycles", to align with Red Hat documentation standards.

Solution description:
Update 4 user-facing strings in the lifecycle metadata popover footer:

  • "OpenShift Operator lifecycle" → "OpenShift Operator life cycle"
  • "OpenShift lifecycle ({{version}})" → "OpenShift life cycle ({{version}})"
  • "Red Hat product lifecycles" → "Red Hat product life cycles"
  • "Lifecycle dates" → "Life cycle dates"

Updates both the component (operator-lifecycle-status.tsx) and locale file (olm.json). Code identifiers, file names, and backend log/error messages are unchanged.

Screenshots / screen recording:

Test setup:
Requires a cluster with the OPERATOR_LIFECYCLE_METADATA feature flag enabled and operators with lifecycle metadata available.

Test cases:

  • Verify the lifecycle popover header shows "Life cycle dates"
  • Verify the popover footer links read "OpenShift Operator life cycle", "OpenShift life cycle (4.x)", and "Red Hat product life cycles"
  • Verify no regressions on the Installed Operators list page

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
Follow-up to #16655 and #16551.

Reviewers and assignees:
/assign @perdasilva

Summary by CodeRabbit

  • Documentation
    • Updated user-facing terminology to use “life cycle” instead of “lifecycle” in operator status labels and related translation text.
    • Refreshed the wording for OpenShift, Red Hat product, and lifecycle dates links and headings to match the new phrasing.

…data UI strings

Update user-facing strings to use "life cycle" and "life cycles" instead
of "lifecycle" and "lifecycles" per docs review feedback.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@perdasilva: This pull request references CONSOLE-5271 which is a valid jira issue.

Details

In response to this:

Analysis / Root cause:
Docs review feedback identified that user-facing strings in the operator lifecycle metadata UI should use "life cycle" (two words) and "life cycles" instead of "lifecycle" and "lifecycles", to align with Red Hat documentation standards.

Solution description:
Update 4 user-facing strings in the lifecycle metadata popover footer:

  • "OpenShift Operator lifecycle" → "OpenShift Operator life cycle"
  • "OpenShift lifecycle ({{version}})" → "OpenShift life cycle ({{version}})"
  • "Red Hat product lifecycles" → "Red Hat product life cycles"
  • "Lifecycle dates" → "Life cycle dates"

Updates both the component (operator-lifecycle-status.tsx) and locale file (olm.json). Code identifiers, file names, and backend log/error messages are unchanged.

Screenshots / screen recording:

Test setup:
Requires a cluster with the OPERATOR_LIFECYCLE_METADATA feature flag enabled and operators with lifecycle metadata available.

Test cases:

  • Verify the lifecycle popover header shows "Life cycle dates"
  • Verify the popover footer links read "OpenShift Operator life cycle", "OpenShift life cycle (4.x)", and "Red Hat product life cycles"
  • Verify no regressions on the Installed Operators list page

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
Follow-up to #16655 and #16551.

Reviewers and assignees:
/assign @perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from TheRealJon and cajieh June 29, 2026 09:29
@openshift-ci openshift-ci Bot added component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4dae601f-7ae5-409c-85be-d14cf7fabe19

📥 Commits

Reviewing files that changed from the base of the PR and between c7f0a38 and 3f8278f.

📒 Files selected for processing (2)
  • frontend/packages/operator-lifecycle-manager/locales/en/olm.json
  • frontend/packages/operator-lifecycle-manager/src/components/operator-lifecycle-status.tsx

Walkthrough

Updates "lifecycle" terminology to "life cycle" (two words) in four i18n translation keys in olm.json and their corresponding string references in operator-lifecycle-status.tsx.

Lifecycle terminology update

Layer / File(s) Summary
i18n keys and UI string updates
frontend/packages/operator-lifecycle-manager/locales/en/olm.json, frontend/packages/operator-lifecycle-manager/src/components/operator-lifecycle-status.tsx
Four translation keys and their UI string usages are renamed from "lifecycle"/"lifecycles" to "life cycle"/"life cycles" across the JSON locale file and the component.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, specific, and accurately describes the main change to operator lifecycle metadata strings.
Description check ✅ Passed The description includes the required sections and clearly explains the root cause, solution, tests, and context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only updates static locale/component copy; no test files or Ginkgo titles were added/changed, and the touched files contain no It/Describe/Context/When strings.
Test Structure And Quality ✅ Passed PR only changes i18n strings in TSX/JSON; no Ginkgo tests or cluster-interaction test code were modified, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; only string literals in a component and locale file changed, and no MicroShift-unsafe test constructs were found.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only string/locale updates changed; no Ginkgo e2e tests or multi-node/HA assumptions were added, so SNO compatibility is not impacted.
Topology-Aware Scheduling Compatibility ✅ Passed Only UI/i18n strings changed in operator-lifecycle-status.tsx and olm.json; no topology, affinity, replica, or nodeSelector logic was added.
Ote Binary Stdout Contract ✅ Passed The PR only renames localized UI strings in a React component and JSON locale file; no main/init/suite-level stdout or logging writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only i18n string updates in TSX/JSON; no new Ginkgo e2e tests, IPv4 assumptions, or external connectivity code were added.
No-Weak-Crypto ✅ Passed Changed files only update i18n strings; scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons.
Container-Privileges ✅ Passed Touched files are only locale/TSX text updates; no manifest fields like privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation were present.
No-Sensitive-Data-In-Logs ✅ Passed Changed files only update UI strings; no console/logger calls or sensitive-data patterns were found in the modified component or locale entries.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@perdasilva

Copy link
Copy Markdown
Author

Docs Approver:
cc @jseseCCS

PX Approver:
cc @rh-joshbeverly

@perdasilva

Copy link
Copy Markdown
Author

/retest

@rh-joshbeverly

Copy link
Copy Markdown

/label px-approved

@openshift-ci openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@TheRealJon TheRealJon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TheRealJon

Copy link
Copy Markdown
Member

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@TheRealJon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants