Skip to content

CONSOLE-5238: Remove unused telemetry Cypress integration tests#16685

Open
rhamilto wants to merge 1 commit into
openshift:mainfrom
rhamilto:CONSOLE-5238
Open

CONSOLE-5238: Remove unused telemetry Cypress integration tests#16685
rhamilto wants to merge 1 commit into
openshift:mainfrom
rhamilto:CONSOLE-5238

Conversation

@rhamilto

@rhamilto rhamilto commented Jun 29, 2026

Copy link
Copy Markdown
Member

Analysis / Root cause:
The console-telemetry-plugin has Cypress integration tests that are never run in CI — no Prow scenario or CI configuration invokes them. The three test-cypress-telemetry* yarn scripts in frontend/package.json are dead code. Additionally, the Playwright config lists a telemetry project but no Playwright telemetry tests exist.

Solution description:

  • Delete the entire frontend/packages/console-telemetry-plugin/integration-tests/ directory (11 files)
  • Remove test-cypress-telemetry, test-cypress-telemetry-headless, and test-cypress-telemetry-nightly scripts from frontend/package.json
  • Remove --project=telemetry from the test-playwright-admin script
  • Remove 'telemetry' from the Playwright packages array in playwright.config.ts
  • Regenerate yarn.lock

The telemetry plugin itself (src/, console-extensions.json, etc.) is untouched.

Screenshots / screen recording:
N/A — no visual changes.

Test setup:
No special setup required.

Test cases:

  • yarn install completes without errors
  • grep -r "test-cypress-telemetry" frontend/ returns no results
  • frontend/packages/console-telemetry-plugin/src/ and other plugin files remain intact

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

N/A — no runtime changes.

Additional info:
Pure dead code removal. No functional changes.

Summary by CodeRabbit

  • Tests
    • Removed legacy telemetry-specific end-to-end test scripts and configurations.
    • Excluded telemetry from the Playwright admin test set.
    • Cleaned up related integration test assets, helpers, step definitions, and reporting setup.

The telemetry plugin's Cypress integration tests were never wired into
CI (no Prow scenario invokes them), so they are dead code. Remove the
test directory, the associated yarn scripts, and the Playwright config
entry (no Playwright telemetry tests exist either).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9b815f2a-cf02-4a21-b50e-650f6844ae82

📥 Commits

Reviewing files that changed from the base of the PR and between d759f67 and 2bc54c3.

⛔ Files ignored due to path filters (1)
  • frontend/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (13)
  • frontend/package.json
  • frontend/packages/console-telemetry-plugin/integration-tests/.eslintrc
  • frontend/packages/console-telemetry-plugin/integration-tests/cypress.config.js
  • frontend/packages/console-telemetry-plugin/integration-tests/features/customization/customization-of-telemetry-analytics.feature
  • frontend/packages/console-telemetry-plugin/integration-tests/package.json
  • frontend/packages/console-telemetry-plugin/integration-tests/reporter-config.json
  • frontend/packages/console-telemetry-plugin/integration-tests/support/commands/hooks.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/support/commands/index.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/support/pages/functions/telemetryConfiguration.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/support/step-definitions/common/telemetryAnalytics.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/support/step-definitions/customization/customization-of-telemetry-analytics.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/tsconfig.json
  • frontend/playwright.config.ts
💤 Files with no reviewable changes (12)
  • frontend/packages/console-telemetry-plugin/integration-tests/package.json
  • frontend/packages/console-telemetry-plugin/integration-tests/tsconfig.json
  • frontend/packages/console-telemetry-plugin/integration-tests/support/step-definitions/common/telemetryAnalytics.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/features/customization/customization-of-telemetry-analytics.feature
  • frontend/packages/console-telemetry-plugin/integration-tests/reporter-config.json
  • frontend/packages/console-telemetry-plugin/integration-tests/.eslintrc
  • frontend/packages/console-telemetry-plugin/integration-tests/support/step-definitions/customization/customization-of-telemetry-analytics.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/support/commands/hooks.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/support/commands/index.ts
  • frontend/packages/console-telemetry-plugin/integration-tests/cypress.config.js
  • frontend/packages/console-telemetry-plugin/integration-tests/support/pages/functions/telemetryConfiguration.ts
  • frontend/playwright.config.ts

Walkthrough

Removes all Cypress integration test files for the console-telemetry-plugin (config, feature files, step definitions, hooks, page helpers, and supporting configs) and deregisters the telemetry project from the Playwright config and npm test scripts.

Telemetry integration test removal

Layer / File(s) Summary
Remove telemetry from test scripts and Playwright config
frontend/package.json, frontend/playwright.config.ts
Removes three Cypress telemetry npm scripts and the telemetry project from both the test-playwright-admin command and the Playwright packages array.
Remove Cypress telemetry integration test suite
frontend/packages/console-telemetry-plugin/integration-tests/...
Removes all Cypress integration test artifacts: cypress.config.js, .eslintrc, tsconfig.json, package.json, reporter-config.json, the feature file, step definitions, page helpers, and support hooks/commands.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

kind/cypress, jira/valid-reference

Suggested reviewers

  • jhadvig
  • TheRealJon
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing unused telemetry Cypress integration tests.
Description check ✅ Passed The description covers root cause, solution, testing, and impact, with only the reviewers/assignees section left unfilled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo-style test titles were added or edited; the PR only deletes telemetry integration tests and removes a Playwright project entry.
Test Structure And Quality ✅ Passed PR only removes frontend Cypress/Playwright test config; no Go/Ginkgo tests were changed, so the checklist is not applicable.
Microshift Test Compatibility ✅ Passed PASS: The PR only deletes telemetry integration tests and removes test scripts; no new Ginkgo It/Describe/Context tests were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only deletes Cypress telemetry tests and removes Playwright telemetry config, so no SNO assumptions were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only telemetry test scaffolding and package/playwright config changed; no manifests, operators, controllers, or scheduling code were modified.
Ote Binary Stdout Contract ✅ Passed Only test/config deletions changed; no main/TestMain/suite setup or stdout writes were introduced in touched files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only deletes telemetry integration tests and removes Playwright/Cypress scripts; no new Ginkgo e2e tests or external-network code were added.
No-Weak-Crypto ✅ Passed Modified files only remove test configs/scripts; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed PASS: The PR only changes frontend test files/scripts; no K8s/container manifests or privileged settings are added.
No-Sensitive-Data-In-Logs ✅ Passed The PR only removes telemetry test/config files and strips Playwright scripts/projects; no new log statements or secret-bearing literals were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@rhamilto

Copy link
Copy Markdown
Member Author

Tech debt
/label px-approved
/label docs-approved
/verified by CI

@rhamilto

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@rhamilto

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@rhamilto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-playwright 2bc54c3 link false /test e2e-playwright
ci/prow/e2e-gcp-console 2bc54c3 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant