CONSOLE-5238: Remove unused telemetry Cypress integration tests#16685
CONSOLE-5238: Remove unused telemetry Cypress integration tests#16685rhamilto wants to merge 1 commit into
Conversation
The telemetry plugin's Cypress integration tests were never wired into CI (no Prow scenario invokes them), so they are dead code. Remove the test directory, the associated yarn scripts, and the Playwright config entry (no Playwright telemetry tests exist either). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
💤 Files with no reviewable changes (12)
WalkthroughRemoves all Cypress integration test files for the Telemetry integration test removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Tech debt |
|
/retest |
1 similar comment
|
/retest |
|
@rhamilto: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Analysis / Root cause:
The
console-telemetry-pluginhas Cypress integration tests that are never run in CI — no Prow scenario or CI configuration invokes them. The threetest-cypress-telemetry*yarn scripts infrontend/package.jsonare dead code. Additionally, the Playwright config lists atelemetryproject but no Playwright telemetry tests exist.Solution description:
frontend/packages/console-telemetry-plugin/integration-tests/directory (11 files)test-cypress-telemetry,test-cypress-telemetry-headless, andtest-cypress-telemetry-nightlyscripts fromfrontend/package.json--project=telemetryfrom thetest-playwright-adminscript'telemetry'from the Playwrightpackagesarray inplaywright.config.tsyarn.lockThe telemetry plugin itself (
src/,console-extensions.json, etc.) is untouched.Screenshots / screen recording:
N/A — no visual changes.
Test setup:
No special setup required.
Test cases:
yarn installcompletes without errorsgrep -r "test-cypress-telemetry" frontend/returns no resultsfrontend/packages/console-telemetry-plugin/src/and other plugin files remain intactBrowser conformance:
N/A — no runtime changes.
Additional info:
Pure dead code removal. No functional changes.
Summary by CodeRabbit