-
Notifications
You must be signed in to change notification settings - Fork 45
build(deps): bump actions/checkout from 4 to 7 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| goarch: [amd64, arm, arm64, mips64le, ppc64le, riscv64, s390x] | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v7 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n .github/workflows/release.yaml | head -80Repository: openshift/containernetworking-plugins Length of output: 2930 Pin both actions/checkout steps to full SHAs and disable credential persistence. Lines 17 and 72 both use Suggested patch - name: Checkout code
- uses: actions/checkout@v7
+ uses: actions/checkout@<FULL_LENGTH_COMMIT_SHA_FOR_V7>
+ with:
+ persist-credentials: falsePer CI/CD security guidelines: pin actions by full SHA (not tag) and apply credential hardening controls in workflows. 🧰 Tools🪛 zizmor (1.25.2)[warning] 16-17: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 17-17: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSources: Coding guidelines, Linters/SAST tools |
||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
|
|
@@ -69,7 +69,7 @@ jobs: | |
| run: sudo apt-get install dos2unix | ||
|
|
||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v7 | ||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ jobs: | |
| name: Lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n .github/workflows/test.yaml | sed -n '10,120p'Repository: openshift/containernetworking-plugins Length of output: 3943 Pin all checkout actions to full commit SHA and disable credential persistence. All five checkout steps at lines 15, 31, 46, 77, and 108 use the mutable tag Suggested patch pattern (apply to each checkout step)- - uses: actions/checkout@v7
+ - uses: actions/checkout@<FULL_LENGTH_COMMIT_SHA_FOR_V7>
+ with:
+ persist-credentials: false🧰 Tools🪛 zizmor (1.25.2)[warning] 15-15: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 15-15: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) 🤖 Prompt for AI AgentsSources: Coding guidelines, Linters/SAST tools |
||
| - name: setup go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
|
|
@@ -28,7 +28,7 @@ jobs: | |
| name: Verify vendor directory | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
|
|
@@ -43,7 +43,7 @@ jobs: | |
| needs: lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
| - name: setup go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
|
|
@@ -74,7 +74,7 @@ jobs: | |
| run: | | ||
| sudo apt-get install dnsmasq | ||
| sudo systemctl disable --now dnsmasq | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
| - name: setup go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
|
|
@@ -105,7 +105,7 @@ jobs: | |
| needs: build | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
| - name: setup go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/containernetworking-plugins
Length of output: 3564
🏁 Script executed:
cat -n .github/workflows/commands.yml | head -20Repository: openshift/containernetworking-plugins
Length of output: 574
Pin
actions/checkoutto an immutable SHA and disable credential persistence.This step uses a mutable tag (
@v7) instead of a full commit SHA and lacks thepersist-credentials: falseconfiguration. Both are required by the CI/CD security hardening guidelines.Suggested patch
🧰 Tools
🪛 zizmor (1.25.2)
[warning] 11-12: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[error] 12-12: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Sources: Coding guidelines, Linters/SAST tools