Skip to content

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Jan 28, 2026

diff --git a/packages/sample-plugin/plugin-metadata.ts b/packages/sample-plugin/plugin-metadata.ts
index 41f2a83..55b5b48 100644
--- a/packages/sample-plugin/plugin-metadata.ts
+++ b/packages/sample-plugin/plugin-metadata.ts
@@ -5,7 +5,7 @@ const metadata: PluginBuildMetadata = {
   name: 'sample-plugin',
   version: '1.2.3',
   dependencies: {
-    'sample-app': '^1.0.0',
+    'sample-app': 'unknown',
   },
   exposedModules: {
     testComponent: './src/test-component',
$ yarn build
[webpack-cli] Failed to load 'dynamic-plugin-sdk/packages/sample-plugin/webpack.config.ts' config
[webpack-cli] Error: Invalid DynamicRemotePlugin options:
Must be either undefined OR an object with string keys and semver range values
    at new DynamicRemotePlugin (dynamic-plugin-sdk/packages/lib-webpack/dist/index.cjs.js:338:19)
    at Object.<anonymous> (dynamic-plugin-sdk/packages/sample-plugin/webpack.config.ts:18:3)
    at Module._compile (node:internal/modules/cjs/loader:1562:14)
    at Module.m._compile (dynamic-plugin-sdk/node_modules/ts-node/src/index.ts:1618:23)
    at node:internal/modules/cjs/loader:1699:10
    at Object.require.extensions.<computed> [as .ts] (dynamic-plugin-sdk/node_modules/ts-node/src/index.ts:1621:12)
    at Module.load (node:internal/modules/cjs/loader:1313:32)
    at Function._load (node:internal/modules/cjs/loader:1123:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)

@openshift-ci openshift-ci bot requested review from florkbr and karelhala January 28, 2026 21:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026
@logonoff logonoff force-pushed the changelog branch 7 times, most recently from ceabc30 to abf5072 Compare January 28, 2026 22:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.76%. Comparing base (81ef7fb) to head (4481470).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   25.39%   18.76%   -6.63%     
==========================================
  Files          40       59      +19     
  Lines        1213     1753     +540     
  Branches      245      326      +81     
==========================================
+ Hits          308      329      +21     
- Misses        889     1408     +519     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants