Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit#477
Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit#477alebedev87 wants to merge 2 commits into
Conversation
The `serializedMirrorSetYaml` task result has a 4096-byte limit which can be exceeded as `images-mirror-set.yaml` grows. Write the serialized mirror set to `serializedMirrorSetYaml` in the `shared-data` workspace instead, and use the `imageContentSourcesFile` parameter of `eaas-create-ephemeral-cluster-hypershift-aws` to pass it to the `provision-cluster` task.
Mirror `registry.redhat.io/edo/*` repositories to Konflux builds in `quay.io/redhat-user-workloads`, matching the existing mirrors for `registry.stage.redhat.io/edo/*`. This allows the bundle `relatedImages` to reference `registry.redhat.io/edo/*` from the start, avoiding the manual registry change to `registry.stage.redhat.io`.
📝 WalkthroughWalkthroughThis pull request updates Tekton pipeline configuration in two coordinated changes. First, it adds new image digest mirror entries to support external-dns operator images from registry.redhat.io/edo/* with quay.io mirrors for rhel8 and rhel9 variants. Second, it refactors the deploy-fbc-operator pipeline to pass the serialized mirror set configuration via shared workspace instead of task result, updates the Git source for mirror set retrieval, and wires the provision-cluster task to read the mirror configuration from the shared workspace file path. 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/pipelines/deploy-fbc-operator.yaml:
- Around line 180-182: The pipeline currently pins the SOURCE_GIT_REPO to a
personal fork URL ("https://github.com/alebedev87/external-dns-operator") and
SOURCE_GIT_REVISION to "release-1.2.2"; revert these to the canonical upstream
repo and a controlled revision parameter by replacing the fork URL with the
upstream repo URL (e.g., the official external-dns-operator repo) and either set
SOURCE_GIT_REVISION to the upstream branch/tag or wire it to a pipeline
parameter/variable so the canonical source and revision are explicitly
controlled (refer to the env names SOURCE_GIT_REPO and SOURCE_GIT_REVISION in
the deploy-fbc-operator.yaml).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e933bea9-32f4-45ab-a09e-6ac9a126432e
📒 Files selected for processing (2)
.tekton/images-mirror-set.yaml.tekton/pipelines/deploy-fbc-operator.yaml
| value: https://github.com/alebedev87/external-dns-operator | ||
| - name: SOURCE_GIT_REVISION | ||
| value: main | ||
| value: release-1.2.2 |
There was a problem hiding this comment.
Revert temporary fork pin before merge.
Line 180 and Line 182 point mirror-set retrieval to a personal fork/branch (alebedev87/external-dns-operator, release-1.2.2). This is a reliability risk for main because pipeline behavior depends on non-canonical repo state and branch lifetime. Please switch this back to the upstream canonical source (or make it an explicit, controlled parameter).
Proposed fix
- name: SOURCE_GIT_URL
- value: https://github.com/alebedev87/external-dns-operator
+ value: https://github.com/openshift/external-dns-operator
- name: SOURCE_GIT_REVISION
- value: release-1.2.2
+ value: main📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| value: https://github.com/alebedev87/external-dns-operator | |
| - name: SOURCE_GIT_REVISION | |
| value: main | |
| value: release-1.2.2 | |
| value: https://github.com/openshift/external-dns-operator | |
| - name: SOURCE_GIT_REVISION | |
| value: main |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/pipelines/deploy-fbc-operator.yaml around lines 180 - 182, The
pipeline currently pins the SOURCE_GIT_REPO to a personal fork URL
("https://github.com/alebedev87/external-dns-operator") and SOURCE_GIT_REVISION
to "release-1.2.2"; revert these to the canonical upstream repo and a controlled
revision parameter by replacing the fork URL with the upstream repo URL (e.g.,
the official external-dns-operator repo) and either set SOURCE_GIT_REVISION to
the upstream branch/tag or wire it to a pipeline parameter/variable so the
canonical source and revision are explicitly controlled (refer to the env names
SOURCE_GIT_REPO and SOURCE_GIT_REVISION in the deploy-fbc-operator.yaml).
There was a problem hiding this comment.
Right, this is done for a purpose of testing the changes. The commit which adds it will be removed.
There was a problem hiding this comment.
@alebedev87 Understood — thanks for the clarification. Since the PR description already calls it out as temporary, just make sure it's reverted before the PR is merged so the pipeline on main always pulls from the canonical upstream source. No further action needed on my end.
alebedev87
changed the title
registry.redhat.io/edo/* image mirrors and fix mirror set size limit
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
alebedev87
changed the title
registry.redhat.io/edo/* image mirrors and fix mirror set size limit
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Pass the serialized image mirror set via the
shared-dataworkspace instead of a Tekton task result to avoid the 4096-byte size limit. Use theimageContentSourcesFileparameter ofeaas-create-ephemeral-cluster-hypershift-awsstep action.Add
registry.redhat.io/edo/*mirror entries pointing to Konflux builds, matching the existingregistry.stage.redhat.io/edo/*mirrors. This allows the bundlerelatedImagesto referenceregistry.redhat.io/edo/*from the start, avoiding the manual registry change toregistry.stage.redhat.io.