Skip to content

OCPBUGS-91656: fix(test): add retry logic to GetLogs in Karpenter kubelet propagatio… #8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 25, 2026
+13 −7
Merged

OCPBUGS-91656: fix(test): add retry logic to GetLogs in Karpenter kubelet propagatio… #8805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions test/e2e/karpenter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,13 +1325,19 @@ func testKubeletPropagation(ctx context.Context, mgtClient, guestClient crclient
g.Expect(p.Status.Phase).To(BeElementOf(corev1.PodSucceeded, corev1.PodFailed))
}).WithTimeout(5 * time.Minute).WithPolling(5 * time.Second).Should(Succeed())

// Always fetch and log the pod output so it's visible in the test run
logReq := guestClientset.CoreV1().Pods(checkerPod.Namespace).GetLogs(checkerPod.Name, &corev1.PodLogOptions{Container: "checker"})
logStream, err := logReq.Stream(ctx)
g.Expect(err).NotTo(HaveOccurred())
defer logStream.Close()
logBytes, err := io.ReadAll(logStream)
g.Expect(err).NotTo(HaveOccurred())
// Fetch pod output with retries — the kubelet serving cert on freshly
// provisioned Karpenter nodes may not be ready immediately after the
// node is marked Ready, causing transient TLS or HTTP/2 errors on the
// proxied log request.
var logBytes []byte
g.Eventually(func(g Gomega) {
logReq := guestClientset.CoreV1().Pods(checkerPod.Namespace).GetLogs(checkerPod.Name, &corev1.PodLogOptions{Container: "checker"})
logStream, err := logReq.Stream(ctx)
g.Expect(err).NotTo(HaveOccurred())
defer logStream.Close()
logBytes, err = io.ReadAll(logStream)
g.Expect(err).NotTo(HaveOccurred())
}).WithTimeout(2 * time.Minute).WithPolling(10 * time.Second).Should(Succeed())
t.Logf("kubelet-config-checker output:\n%s", string(logBytes))

// Assert the pod succeeded (grep chain exited 0 = all fields found)
Expand Down