OCPBUGS-77261: Increase timeout for waiting control plane

[mhanss]

This PR fixes an issue with cluster-managed networking on real bare-metal hardware, where the system may take longer to configure networking. With the original 60-minute timeout, control plane nodes may fail to join the bootstrap node, leading to installation failures. This issue does not occur with user-managed networking because the networking is already configured by the user, making the 60-minute timeout sufficient.

Summary by CodeRabbit

• Chores
  • Updated timeout configuration for the control plane initialization stage to enhance system reliability.

[openshift-ci-robot]

@mhanss: This pull request references Jira Issue OCPBUGS-77261, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR fixes an issue with cluster-managed networking on real bare-metal hardware, where the system may take longer to configure networking. With the original 60-minute timeout, control plane nodes may fail to join the bootstrap node, leading to installation failures. This issue does not occur with user-managed networking because the networking is already configured by the user, making the 60-minute timeout sufficient.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bfournie]

/lgtm

[mhanss]

/jira refresh

[openshift-ci-robot]

@mhanss: This pull request references Jira Issue OCPBUGS-77261, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mhanss.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@mhanss: This pull request references Jira Issue OCPBUGS-77261, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3a135e39-daf9-479a-bbf4-1983dbbfe7ec

📥 Commits

Reviewing files that changed from the base of the PR and between 4006847 and e1515d3.

📒 Files selected for processing (1)

• data/data/agent/files/usr/local/share/assisted-service/assisted-service.env.template

---

Walkthrough

A new environment variable HOST_STAGE_WAITING_FOR_CONTROL_PLANE_TIMEOUT with a value of 90 minutes was added to the assisted-service configuration template.

Changes

Cohort / File(s)	Summary
Configuration Addition data/data/agent/files/usr/local/share/assisted-service/assisted-service.env.template	Added environment variable HOST_STAGE_WAITING_FOR_CONTROL_PLANE_TIMEOUT=90m for control plane timeout configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: increasing a timeout for waiting on the control plane, which matches the single environment variable addition shown in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	This custom check validates Ginkgo test names for stability, but the PR only modifies an environment variable template file, not test files.
Test Structure And Quality	✅ Passed	PR only modifies a configuration file, not Ginkgo test code. Custom check for test quality is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@mhanss: This pull request references Jira Issue OCPBUGS-77261, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

This PR fixes an issue with cluster-managed networking on real bare-metal hardware, where the system may take longer to configure networking. With the original 60-minute timeout, control plane nodes may fail to join the bootstrap node, leading to installation failures. This issue does not occur with user-managed networking because the networking is already configured by the user, making the 60-minute timeout sufficient.

Summary by CodeRabbit

• Chores
• Updated timeout configuration for the control plane initialization stage to enhance system reliability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mhanss.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@mhanss: This pull request references Jira Issue OCPBUGS-77261, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

In response to this:

This PR fixes an issue with cluster-managed networking on real bare-metal hardware, where the system may take longer to configure networking. With the original 60-minute timeout, control plane nodes may fail to join the bootstrap node, leading to installation failures. This issue does not occur with user-managed networking because the networking is already configured by the user, making the 60-minute timeout sufficient.

Summary by CodeRabbit

• Chores
• Updated timeout configuration for the control plane initialization stage to enhance system reliability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mhanss]

/test okd-scos-images

[mhanss]

/verified bypass

[openshift-ci-robot]

@mhanss: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andfasano]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• data/data/agent/OWNERS [andfasano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mhanss]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@mhanss: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mhanss]

/test okd-scos-images

[openshift-ci]

@mhanss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry	e1515d3	link	false	/test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-agent-two-node-fencing-ipv4	e1515d3	link	false	/test e2e-agent-two-node-fencing-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mhanss]

/test okd-scos-images

[openshift-ci-robot]

@mhanss: Jira Issue Verification Checks: Jira Issue OCPBUGS-77261
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77261 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This PR fixes an issue with cluster-managed networking on real bare-metal hardware, where the system may take longer to configure networking. With the original 60-minute timeout, control plane nodes may fail to join the bootstrap node, leading to installation failures. This issue does not occur with user-managed networking because the networking is already configured by the user, making the 60-minute timeout sufficient.

Summary by CodeRabbit

• Chores
• Updated timeout configuration for the control plane initialization stage to enhance system reliability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@mhanss: new pull request created: #10383

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.