Add lint, i18n and unit tests to CI pipeline

[kyoto]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raptorsun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0d91eb10-62f9-4add-9cf5-c7220fa04485

📥 Commits

Reviewing files that changed from the base of the PR and between 382e0cf and 811a227.

📒 Files selected for processing (4)

• .tekton/integration-tests/lightspeed-agentic-console-pre-commit.yaml
• locales/en/plugin__lightspeed-agentic-console-plugin.json
• src/components/proposals/ProposalDetailPage.tsx
• src/hooks/useStageApproval.ts

✅ Files skipped from review due to trivial changes (3)

• src/hooks/useStageApproval.ts
• src/components/proposals/ProposalDetailPage.tsx
• locales/en/plugin__lightspeed-agentic-console-plugin.json

🚧 Files skipped from review as they are similar to previous changes (1)

• .tekton/integration-tests/lightspeed-agentic-console-pre-commit.yaml

---

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Added clearer messaging for the agentic system’s suspended state.
  • Updated approval retry labels to consistently include the retry count (e.g., “{{num}} retries”).
• Bug Fixes
  • Improved formatting of approval tooltips and proposal approval page layout, preserving existing behavior and permissions.

Walkthrough

Adds a Tekton pre-commit pipeline for the agentic console, and updates proposal locale strings plus formatting in approval-related UI code.

Changes

Tekton pre-commit pipeline

Layer / File(s)	Summary
Pipeline manifest and metadata .tekton/integration-tests/lightspeed-agentic-console-pre-commit.yaml	Defines the new lightspeed-agentic-console-pre-commits pipeline and its SNAPSHOT and test-name parameters.
Snapshot extraction and lint tasks .tekton/integration-tests/lightspeed-agentic-console-pre-commit.yaml	Adds extract-snapshot-metadata to parse SNAPSHOT into console-image and commit, then runs lint after cloning and checking out that commit.

Proposal UI text and layout

Layer / File(s)	Summary
Locale strings locales/en/plugin__lightspeed-agentic-console-plugin.json	Adds suspension-state messaging and removes the standalone Approve with retries label.
Approval tooltips src/components/proposals/ProposalDetailPage.tsx	Reformats the approval and execution-approval tooltips into multiline t(...) calls without changing trigger conditions.
Page layout and hook formatting src/components/proposals/ProposalDetailPage.tsx, src/hooks/useStageApproval.ts	Reformats the trigger-bootstrap section, proposal detail layout, and useStageApproval return object without changing rendered conditions or returned fields.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided, so there is not enough content to assess beyond the code changes.	Add a brief description of the CI pipeline changes and what the new pre-commit pipeline validates.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding lint, i18n, and unit test steps to the CI pipeline.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tekton/integration-tests/lightspeed-agentic-console-pre-commit.yaml:
- Around line 44-46: The Tekton step in lightspeed-agentic-console-pre-commit
currently writes the jq results directly into the console-image and commit
result files without verifying they are present. Add explicit checks around the
jq lookups for lightspeed-agentic-console in the snapshot, and if
.containerImage or .source.git.revision is empty or null, emit a clear error and
exit non-zero before writing results. Keep the validation in the same step
script so the failure is caught before later git commands consume bad values.
- Around line 10-12: The default SNAPSHOT payload is missing the
source.git.revision field that the commit extraction path expects, so the lint
task ends up with a null commit. Update the SNAPSHOT default in the pipeline
parameter definition to include a valid source.git.revision value that matches
what the extraction logic in the lint task reads, and keep the structure aligned
with the application snapshot consumed by the pre-commit flow.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ab400503-5186-4177-a29f-632f45e0403f

📥 Commits

Reviewing files that changed from the base of the PR and between f2b5c33 and 382e0cf.

📒 Files selected for processing (4)

• .tekton/integration-tests/lightspeed-agentic-console-pre-commit.yaml
• locales/en/plugin__lightspeed-agentic-console-plugin.json
• src/components/proposals/ProposalDetailPage.tsx
• src/hooks/useStageApproval.ts

[JoaoFula]

/lgtm

[JoaoFula]

/retest