Skip to content

OLS-3277: display approver identity on proposal detail page#64

Open
vimalk78 wants to merge 1 commit into
openshift:mainfrom
vimalk78:ols-3277-approver-display
Open

OLS-3277: display approver identity on proposal detail page#64
vimalk78 wants to merge 1 commit into
openshift:mainfrom
vimalk78:ols-3277-approver-display

Conversation

@vimalk78

@vimalk78 vimalk78 commented Jun 25, 2026

Copy link
Copy Markdown

Summary

  • Add ApproverInfo type to the proposal model (username, uid, approvedAt)
  • Display approver username and timestamp on the Overview tab after approval
  • Gracefully omit the section when spec.approver is absent (pre-webhook approvals)

The approver identity is injected by the operator's mutating admission webhook on ProposalApproval patch — the console reads it from the CR watch.

Test plan

  • Approve a proposal via console, verify "Approved By" shows username and timestamp on Overview tab
  • View a pre-existing proposal with no approver field — no errors, section absent
  • npm run build passes
  • Lint errors are all pre-existing (6 errors, 2 warnings in unrelated files)
image

Show spec.approver username and approvedAt timestamp on the Overview
tab after approval. Data is injected by the mutating admission webhook
and read from the ProposalApproval CR watch.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 25, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 25, 2026

Copy link
Copy Markdown

@vimalk78: This pull request references OLS-3277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add ApproverInfo type to the proposal model (username, uid, approvedAt)
  • Display approver username and timestamp on the Overview tab after approval
  • Gracefully omit the section when spec.approver is absent (pre-webhook approvals)

The approver identity is injected by the operator's mutating admission webhook on ProposalApproval patch — the console reads it from the CR watch.

Test plan

  • Approve a proposal via console, verify "Approved By" shows username and timestamp on Overview tab
  • View a pre-existing proposal with no approver field — no errors, section absent
  • npm run build passes
  • Lint errors are all pre-existing (6 errors, 2 warnings in unrelated files)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vimalk78, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aa64eed9-e6ed-4a12-a14f-9bc77a406274

📥 Commits

Reviewing files that changed from the base of the PR and between 317433e and 24d7d07.

📒 Files selected for processing (3)
  • src/components/proposals/ProposalDetailPage.tsx
  • src/hooks/useStageApproval.ts
  • src/models/proposal.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from blublinsky and onmete June 25, 2026 10:18
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kyoto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants