OCPBUGS-74223: Re-order logger setting to eliminate race condition#5691
OCPBUGS-74223: Re-order logger setting to eliminate race condition#5691isabella-janssen wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74223, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6010218 to
4418a37
Compare
|
/jira refresh |
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74223, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4418a37 to
f013cc9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Pre-merge testing: Environment Setup: Steps:
|
|
/label qe-approved |
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74223, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ptalgulk01: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.21 release-4.20 release-4.19 |
|
@isabella-janssen: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test unit |
|
/test e2e-aws-ovn-upgrade |
|
@isabella-janssen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closes: OCPBUGS-74223
- What I did
The moves the logger initialization before any controller-runtime code runs to eliminate the race condition intermittently occurring as described in the Jira ticket.
- How to verify it
We should no longer see the
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.error when observing machine-config-server logs.- Description for the changelog
OCPBUGS-74223: Re-order logger setting to eliminate race condition