OCPBUGS-10431: remove staticPodPath from worker kubelet config

[harche]

- What I did
Removed staticPodPath from the worker node kubelet configuration template.

Fixes: https://issues.redhat.com/browse/OCPBUGS-10431

- How to verify it

1. Deploy a cluster with this change
2. SSH into a worker node and verify /etc/kubernetes/kubelet.conf does not contain staticPodPath
3. SSH into a control plane node and verify staticPodPath: /etc/kubernetes/manifests is still present

- Description for the changelog

Remove staticPodPath from worker kubelet config to resolve DISA STIG V-242397 compliance finding.

[openshift-ci-robot]

@harche: This pull request references Jira Issue OCPBUGS-10431, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Removed staticPodPath from the worker node kubelet configuration template.

Fixes: https://issues.redhat.com/browse/OCPBUGS-10431

- How to verify it

1. Deploy a cluster with this change
2. SSH into a worker node and verify /etc/kubernetes/kubelet.conf does not contain staticPodPath
3. SSH into a control plane node and verify staticPodPath: /etc/kubernetes/manifests is still present

- Description for the changelog

Remove staticPodPath from worker kubelet config to resolve DISA STIG V-242397 compliance finding.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[harche]

/jira refresh

[openshift-ci-robot]

@harche: This pull request references Jira Issue OCPBUGS-10431, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[harche]

/jira refresh

[openshift-ci-robot]

@harche: This pull request references Jira Issue OCPBUGS-10431, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harche
Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• templates/worker/01-worker-kubelet/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harche]

/retest-required

[harche]

/retest

[harche]

/cc @haircommander

[openshift-ci]

@harche: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift	de2e5d1	link	true	/test e2e-hypershift
ci/prow/e2e-aws-ovn	de2e5d1	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade	de2e5d1	link	true	/test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[haircommander]

I think a better alternative would be to relax the validation to allow the worker pool to set its static pod path to "" but not control plane. Is this something you want to try @harche ?