Skip to content

NO-ISSUE: Increase timeout + interval for OCL test cleanup #5732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umohnani8 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-ISSUE: Increase timeout + interval for OCL test cleanup #5732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dc5eca
Increase timeout for cleanup for singular OCL suite
umohnani8 Mar 3, 2026
efe0cce
Increase timeout + interval for OCL test cleanup
umohnani8 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions test/e2e-ocl-shared/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,14 @@ func CleanupEphemeralBuildObjects(t *testing.T, cs *framework.ClientSet) {
require.NoError(t, err)

// Helper function to create a fresh timeout context for each resource verification.
// Each resource gets its own 2-minute timeout to prevent slow deletions from
// consuming the timeout budget of other resources. Use a slower poll interval
// (3s instead of 1s) to reduce API call rate and avoid rate limiting.
// Each resource gets its own 3-minute timeout to prevent slow deletions from
// consuming the timeout budget of other resources. Use a 5-second poll interval
// to significantly reduce API call rate and avoid exhausting the rate limiter
// (~36 attempts per resource, vs 120 attempts with 1s interval).
newCleanupAssertion := func() *helpers.Assertions {
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
t.Cleanup(cancel)
return helpers.AssertClientSet(t, cs).WithContext(ctx).WithPollInterval(3 * time.Second).Eventually()
return helpers.AssertClientSet(t, cs).WithContext(ctx).WithPollInterval(5 * time.Second).Eventually()
}

if len(secretList.Items) == 0 {
Expand Down
11 changes: 6 additions & 5 deletions test/e2e-ocl/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,13 +314,14 @@ func cleanupEphemeralBuildObjects(t *testing.T, cs *framework.ClientSet) {
require.NoError(t, err)

// Helper function to create a fresh timeout context for each resource verification.
// Each resource gets its own 2-minute timeout to prevent slow deletions from
// consuming the timeout budget of other resources. Use a slower poll interval
// (3s instead of 1s) to reduce API call rate and avoid rate limiting.
// Each resource gets its own 3-minute timeout to prevent slow deletions from
// consuming the timeout budget of other resources. Use a 5-second poll interval
// to significantly reduce API call rate and avoid exhausting the rate limiter
// (~36 attempts per resource, vs 120 attempts with 1s interval).
newCleanupAssertion := func() *helpers.Assertions {
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
t.Cleanup(cancel)
return helpers.AssertClientSet(t, cs).WithContext(ctx).WithPollInterval(3 * time.Second).Eventually()
return helpers.AssertClientSet(t, cs).WithContext(ctx).WithPollInterval(5 * time.Second).Eventually()
}

if len(secretList.Items) == 0 {
Expand Down