OCPBUGS-94000: Remove sensitive ControllerConfig logging#6245
OCPBUGS-94000: Remove sensitive ControllerConfig logging#6245dkhater-redhat wants to merge 1 commit into
Conversation
The bootstrap MCS was logging the entire ControllerConfig YAML which contains sensitive data (internalRegistryPullSecret). This causes LeakTK to redact CI artifacts, preventing bootstrap failure debugging. The file read is already logged on line 116, which is sufficient.
WalkthroughRemoves a single log statement in ChangesLog cleanup in bootstrap server
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verified bypass |
|
/jira refresh |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkhater-redhat, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified bypass |
|
@dkhater-redhat: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@dkhater-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The bootstrap MCS was logging the entire ControllerConfig YAML which contains sensitive data (internalRegistryPullSecret). This causes LeakTK to redact CI artifacts, preventing bootstrap failure debugging.
The file read is already logged on line 116, which is sufficient.
- What I did
- How to verify it
- Description for the changelog
Summary by CodeRabbit