Skip to content

NO-JIRA: Openshift-Only: skip graceful restart in the frr-k8s e2e tests#235

Open
karampok wants to merge 1 commit into
openshift:release-4.18from
karampok:skip-gr-418
Open

NO-JIRA: Openshift-Only: skip graceful restart in the frr-k8s e2e tests#235
karampok wants to merge 1 commit into
openshift:release-4.18from
karampok:skip-gr-418

Conversation

@karampok

Copy link
Copy Markdown

The GR is abandoned OCP feature and those tests are failing downstream.

[FAIL] Session Session parameters Establishes sessions with graceful restart [It] IPV4
/root/dev-scripts/frr/e2etests/tests/session.go:259
[FAIL] Establish BGP session with EnableGracefulRestart When restarting the frrk8s deamon pods external BGP peer maintains routes [It] IPV4
/root/dev-scripts/frr/e2etests/tests/graceful_restart.go:128

The GR is abandoned OCP feature and those tests are failing
downstream.

```
[FAIL] Session Session parameters Establishes sessions with graceful restart [It] IPV4
/root/dev-scripts/frr/e2etests/tests/session.go:259
[FAIL] Establish BGP session with EnableGracefulRestart When restarting the frrk8s deamon pods external BGP peer maintains routes [It] IPV4
/root/dev-scripts/frr/e2etests/tests/graceful_restart.go:128
```

Signed-off-by: Konstantinos Karampogias <karampok@gmail.com>
@karampok karampok requested a review from russellb as a code owner April 29, 2025 11:45
@openshift-ci openshift-ci Bot requested review from fedepaol and oribon April 29, 2025 11:46
@openshift-bot

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2025
@openshift-bot

Copy link
Copy Markdown

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 28, 2025
@openshift-bot

Copy link
Copy Markdown

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Sep 28, 2025
@openshift-ci

openshift-ci Bot commented Sep 28, 2025

Copy link
Copy Markdown

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karampok

karampok commented Feb 4, 2026

Copy link
Copy Markdown
Author

/reopen

@openshift-ci openshift-ci Bot reopened this Feb 4, 2026
@openshift-ci

openshift-ci Bot commented Feb 4, 2026

Copy link
Copy Markdown

@karampok: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oribon

oribon commented Feb 4, 2026

Copy link
Copy Markdown

/remove-lifecycle rotten
/lgtm
/approve

@openshift-ci openshift-ci Bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 4, 2026
@openshift-ci

openshift-ci Bot commented Feb 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karampok, oribon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@oribon

oribon commented Feb 8, 2026

Copy link
Copy Markdown

/retitle NO-JIRA: Openshift-Only: skip graceful restart in the frr-k8s e2e tests

@openshift-ci openshift-ci Bot changed the title Openshift-Only: skip graceful restart in the frr-k8s e2e tests NO-JIRA: Openshift-Only: skip graceful restart in the frr-k8s e2e tests Feb 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@karampok: This pull request explicitly references no jira issue.

Details

In response to this:

The GR is abandoned OCP feature and those tests are failing downstream.

[FAIL] Session Session parameters Establishes sessions with graceful restart [It] IPV4
/root/dev-scripts/frr/e2etests/tests/session.go:259
[FAIL] Establish BGP session with EnableGracefulRestart When restarting the frrk8s deamon pods external BGP peer maintains routes [It] IPV4
/root/dev-scripts/frr/e2etests/tests/graceful_restart.go:128

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oribon

oribon commented Feb 8, 2026

Copy link
Copy Markdown

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 8, 2026
@oribon

oribon commented Feb 8, 2026

Copy link
Copy Markdown

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@oribon: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Mar 2, 2026

Copy link
Copy Markdown

@karampok: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants